Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mp7particledata): match mp7 order in to_coords()/to_prp() #2172

Merged
merged 3 commits into from
May 1, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented May 1, 2024

  • return the same particle order from to_coords() and to_prp() as generated by MP7 — preserves particle indexing for MF6 PRT, making it easier to compare results, though something like this may still be handy
  • refactoring/cleanup, factor out helper methods get_cell_release_points(), get_face_release_points()
    • defer materialization — return iterators not lists so the consumer can control memory use, previously done for to_coords() and to_prp() but not get_release_points(), might be relevant for very large release configurations
  • test-drive a pytest plugin for previously hardcoded snapshot tests, introduce some fixtures in autotest/conftest.py for nicer array snapshots than the default format, maybe these could live in devtools if they see wider use?

@wpbonelli wpbonelli added enhancement performance dependencies Pull requests that update a dependency file labels May 1, 2024
@wpbonelli wpbonelli marked this pull request as ready for review May 1, 2024 11:35
@wpbonelli
Copy link
Member Author

Changes here should only affect PRT, I will merge aggressively since @aprovost-usgs and I are dogfooding this and the tentative snapshot approach has been discussed offline with @langevin-usgs. Note, contributors will need to install the plugin

@wpbonelli wpbonelli merged commit c7af787 into modflowpy:develop May 1, 2024
24 checks passed
@wpbonelli wpbonelli deleted the particledata branch May 1, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant