Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(deprecations): deprecate flopy.mf6.utils.reference module #2375

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Nov 18, 2024

The flopy.mf6.utils.reference module contains spatial reference classes similar to those deprecated/removed in #1914, #1892, and #1200. These are not in use anywhere in the codebase. The flopy.discretization module can/should be used instead?

The deprecated module contains spatial reference classes similar to those deprecated/removed in modflowpy#1914, modflowpy#1892, and modflowpy#1200. These are not in use anywhere in the codebase. The flopy.discretization module can be used instead.
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.9%. Comparing base (bb9824e) to head (f93571a).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff            @@
##           develop   #2375     +/-   ##
=========================================
+ Coverage     68.4%   75.9%   +7.5%     
=========================================
  Files          294     294             
  Lines        59390   61638   +2248     
=========================================
+ Hits         40652   46841   +6189     
+ Misses       18738   14797   -3941     
Files with missing lines Coverage Δ
flopy/mf6/utils/reference.py 0.0% <ø> (ø)

... and 229 files with indirect coverage changes

---- 🚨 Try these New Features:

@wpbonelli wpbonelli marked this pull request as ready for review November 18, 2024 18:01
Copy link
Contributor

@mwtoews mwtoews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, looks good. I've pushed a commit to use Sphinx's cross-references.

@wpbonelli wpbonelli added this to the 3.9 milestone Nov 19, 2024
@wpbonelli wpbonelli merged commit 1993af1 into modflowpy:develop Nov 19, 2024
23 checks passed
@wpbonelli wpbonelli deleted the spatial-reference branch November 19, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants