chore(dependencies): update conda environment #2414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpbonelli
added
bug
dependencies
wpbonelli
commented
Jan 10, 2025
| @@ -106,15 +106,6 @@ def pytest_addoption(parser): | |||
| "check patch collections or figure & axis properties.)", | |||
| ) | |||
|
|
|||
| # for test_generate_classes.py | |||
There was a problem hiding this comment.
this should have been removed with #2412
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2414 +/- ##
=========================================
+ Coverage 68.4% 76.3% +7.9%
=========================================
Files 294 294
Lines 59390 59805 +415
=========================================
+ Hits 40652 45662 +5010
+ Misses 18738 14143 -4595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
environment.ymlwas missing a few optional/developer dependencies we've recently added topyproject.toml. Bring the former into sync with the latter (and list packages in the same order).With luck, conda will eventually be able to consume
pyproject.tomlfiles, and we can removeenvironment.yml. More info at issue 10633 on the conda repo (not linking to avoid the crossref showing up there).There were some old pycharm cell format comments in the notebook scripts which jupytext didn't like, remove them.
This should close #2253. To avoid similar situations in the future, don't skip notebooks due to missing dependencies in CI — we did this for convenient local testing, so tests can run without all optional dependencies, but CI should be strict.