rework dfn -> toml conversion #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deltamarnix
requested changes
Dec 10, 2024
deltamarnix
approved these changes
Dec 10, 2024
TOML conversion as per group discussions and as prototyped in flopy3 in the Jinja PR. This is a nested structure where components have blocks, which have variables, which may be composites of other variables. Add the latest DFNs as well as the converted TOML files. The structure is still tentative and may evolve.
|
After discussion I will close this and move it to devtools |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOML conversion as per group discussions and as prototyped in flopy3 in the Jinja PR.
This is a nested structure where components have blocks, which have variables, which may be composites of other variables, and child relationships are direct, not mediated by
childrenintermediate attributes.Add the latest DFNs as well as the converted TOML files. (Maybe we shouldn't version these?)
The structure is still tentative and may evolve.
The toml dependency is switched to tomlkit. And add boltons as a dependency.
Also, use the default ruff line length of 88.
We could start consuming the TOML definitions for any further prototyping and also in flopy3 shortly.