-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] Create a common API for accessing device file data #35
base: develop
Are you sure you want to change the base?
Conversation
929073b
to
bd2e26e
Compare
I found data inconsistency due to the merge algorithm. Hmpf. |
This leads me to a question. I've found that some hardware, which has several instances on one STM32, the instances are named xxx1, xxx2 etc. But if there is a variant of the STM32 which has a single instance only, sometimes that instance is simply named xxx. Wouldn't it be better, to also name the single instance xxx1? Example: F303K8 has a single CAN. |
Define "better". If ST fails at properly enumerating their peripherals, it becomes difficult to fix this, because this naming is then used in all docs and also in the CMSIS headers (although not consistently 🙄). I'm currently delegating formatting to the HAL library, which may decide to rename instance "" to "1". In general we try to use the datasheet definitions though. |
bd2e26e
to
8736384
Compare
8736384
to
a7f5782
Compare
a7f5782
to
3729b81
Compare
dd5167f
to
aa18ab4
Compare
This is the initial exploration of what a shared API for accessing device file data could look like.
The goal is to decouple the device file data from the underlying format, and to move common algorithms for computing implicit data out of the using library (here modm modules) into modm-devices and to create a proper documented and versioned Python API.
Note: This is all very experimental, even if the technical side of this (ie. moving code) is simple, everything around it (docs, versioning, hosting) is not.
TODO:
cc @rleh @chris-durand @strongly-typed @mikewolfram @dergraaf