-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix STM32H7 dual-core device files #83
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Did you find this out just by looking at the data, or is there a test we could add to the CI to detect this?
I am trying to compile a blink example for a Nucleo H755ZI-Q. Compilation fails without the fix because the |
Please don't merge yet. I have found another issue. There is no Cortex-M4 with a double-precision FPU but the device file has |
The memory layout is not correct for size g devices. The flash address space is not contiguous on those devices. Flash bank 0 ends at |
Then the flash memories should be separated and given to each core separately, the merging will then tag it per core. |
You mean we should assign a core to each half in the device file? Also for size This would hard-code the default usage in the device file. There is nothing that prevents you from reconfiguring the core boot addresses in the option bytes or only using a part of a bank for one core. It's a user choice and not a property of the hardware. I am fine with that limitation for modm but a potential external user of the device files might not. (Is there actually someone using modm-devices for another purpose that is not modm?). |
Good points. Then we need to split the Flash into two areas, not sure what will break in modm if anything. |
0a9ac35
to
1be87eb
Compare
OPENAMP
andRESMGR_UTILITY
software IPs from device files for H7 dual core devices.cortex-m4f
, notcortex-m4fd
)g
devices