-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: Add chromium support #151
Conversation
|
Nice! Good job on the fix! However, I think we should change to import the script using ECMAScript module syntax since it looks cleaner, doesn't pollute the scope with stuff we don't know about, and have cleaner syntax overall when calling the functions. Firefox will support it in version 111, which is released March 14th. This won't require changes to |
10211a3
to
ab8d930
Compare
Also, this does not work...I think you failed to commit the |
Yeah, noticed that too, forced push a change a few seconds ago. |
Opened #152! |
Hmm, I thought I fixed that again. Will take a look! |
ab8d930
to
d855ab7
Compare
c1c1d07
to
5b4f872
Compare
We might be able to solve this by fetching/displaying the welcome document strictly after we have loaded the core wasm, by sending an init event to the main (sync) JS. Or let the worker fetch the document itself |
5b4f872
to
40d510e
Compare
It seems like your last commit solved the problem. I think we are ready to merge it, but we should PR #152 asap to merge it on tuesday when the Firefox update goes stable and we can verify that ES modules work there as well! (Approved) |
Resolves GH-45. This PR adds support for the playground in Chromium browsers. This is done by instantiating the WASM module that contains the compiler inside of a web worker instead of the main thread.