Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace playground with a React project #257

Merged
merged 13 commits into from
May 11, 2023
Merged

Replace playground with a React project #257

merged 13 commits into from
May 11, 2023

Conversation

adelhult
Copy link
Collaborator

@adelhult adelhult commented Apr 25, 2023

Resolves #256. A full rewrite of the playground in React. Feel free to play around with it :). There are still a bunch missing but I think we might as well rebase into main so that I'm not blocking others from contributing.

I also made a few issues for future improvements that we can work on if we have time or think that it would be fun:

@adelhult adelhult force-pushed the adelhult/GH-256/0 branch from 13c4a63 to f12c9c3 Compare April 25, 2023 07:53
@github-actions
Copy link

github-actions bot commented Apr 25, 2023

PR Preview Action 501f138
Preview removed because the pull request was closed.
2023-05-11 09:19 UTC

@adelhult adelhult force-pushed the adelhult/GH-256/0 branch 4 times, most recently from cd4245e to b27aa42 Compare May 2, 2023 20:01
@adelhult adelhult force-pushed the adelhult/GH-256/0 branch 2 times, most recently from 65183cd to 74e46b3 Compare May 10, 2023 13:56
@adelhult adelhult force-pushed the adelhult/GH-256/0 branch from 7e13327 to 02d641c Compare May 10, 2023 16:22
@adelhult adelhult force-pushed the adelhult/GH-256/0 branch from 02d641c to 71649e1 Compare May 10, 2023 16:31
Copy link
Member

@CMDJojo CMDJojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the rewrite! I know you are not quite done yet, but I left some comments on stuff you might have missed! Keep it up :) it looks so good!

.github/workflows/DeployPreview.yml Outdated Show resolved Hide resolved
.github/workflows/DeployMain.yml Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
website/.vite/deps_temp_39fa3b02/package.json Outdated Show resolved Hide resolved
website/src/Homepage.tsx Outdated Show resolved Hide resolved
website/src/main.tsx Show resolved Hide resolved
website/src/welcomeMessage.tsx Outdated Show resolved Hide resolved
@CMDJojo
Copy link
Member

CMDJojo commented May 10, 2023

Also, I noticed that it says "Typing..." as soon as you load the page (when I know that can't be right). Might be configured so that that is displayed when the WASM binary is loaded, but it would be nice if it said like "Loading compiler..." or something that isn't a lie haha

@adelhult adelhult marked this pull request as ready for review May 11, 2023 06:41
@adelhult adelhult force-pushed the adelhult/GH-256/0 branch from 30d7e81 to 665c805 Compare May 11, 2023 09:05
Copy link
Collaborator

@hugomardbrink hugomardbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adelhult adelhult force-pushed the adelhult/GH-256/0 branch from 665c805 to 06b8939 Compare May 11, 2023 09:18
@adelhult adelhult merged commit 501f138 into main May 11, 2023
@adelhult adelhult deleted the adelhult/GH-256/0 branch May 11, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve playground (react rewrite)
3 participants