-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace playground with a React project #257
Conversation
13c4a63
to
f12c9c3
Compare
|
cd4245e
to
b27aa42
Compare
65183cd
to
74e46b3
Compare
7e13327
to
02d641c
Compare
02d641c
to
71649e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work with the rewrite! I know you are not quite done yet, but I left some comments on stuff you might have missed! Keep it up :) it looks so good!
Also, I noticed that it says "Typing..." as soon as you load the page (when I know that can't be right). Might be configured so that that is displayed when the WASM binary is loaded, but it would be nice if it said like "Loading compiler..." or something that isn't a lie haha |
30d7e81
to
665c805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
665c805
to
06b8939
Compare
Resolves #256. A full rewrite of the playground in React. Feel free to play around with it :). There are still a bunch missing but I think we might as well rebase into main so that I'm not blocking others from contributing.
I also made a few issues for future improvements that we can work on if we have time or think that it would be fun: