-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for check/test/clippy/fmt #8
Conversation
We are getting some warning annotations when the CI runs due to actions depending on node 12.
Checkout could be updated to v3 to avoid this but I cannot find anything about updates to actions-rs. I didn't notice them when I made the gist. I think we could just ignore them for now and look at it again later. |
Hmm, seems strange…didn’t notice those warnings at first. Thanks for the heads up! I can see what I find later today. Is there a good way to test-run the actions without pushing it to remote?
Anyways, I think it is fine to ignore for now, and if anyone finds a solution, we can just reference this PR and the original issue from the new PR.
For this to be merged, however, it would be nice if GH-7 gets approved first, since this builds on it.
|
@axoxelol1 regarding your previous comment:
I have now updated checkout to use v3, and changed |
We could also just |
886baff
to
fd13dbe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR attempts to use GitHub Actions as a CI for all pull requests and commits to main. To do this, two things have been done:
.gitignore
was added)RustCI.yml
file was created under.github/workflows
based on this comment from @axoxelol1 (some adjustments were made; names were added, toolchain installation was streamlined and more verbosity was added). But that gist was of good help!The CI runs
check
,test
,clippy
andfmt
.I am unsure if this PR will actually check if the CI workflow works, but let's hope!
Resolves GH-3