Add glue code to fix missing Modula-3 implementations of cabs, frexp, #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and modf. See cm3 issue 1178.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cm3 issue 1178.
This PR creates glue procedures for the Math routines cabs, frexp, and modf.
signgam is left alone---I am not sure it needs any work.
What we do here is use standard call-by-value and standard C types to communicate in the simplest way into a new glue C module, with its own EXTERNAL symbols.
The suspect procedures are unmarked as EXTERNAL in Math.i3 and instead implemented in MathPosix.m3, which calls the new C code with appropriate arguments.
The code has been tested to link with all symbols, but not for functionality. (Prior work does not link, at least not with the C backend.)