-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] Refactor external_call()
and inline _LITRefPackHelper
into VariadicPack
#3632
base: nightly
Are you sure you want to change the base?
[stdlib] Refactor external_call()
and inline _LITRefPackHelper
into VariadicPack
#3632
Conversation
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
…artinvuyk/mojo into add-externalcall-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
!sync |
…-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
…-variadicpack-overload
…artinvuyk/mojo into add-externalcall-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
…-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
CC: @ConnorGray as you have an internal PR up for consolidating |
!sync |
…-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
@ConnorGray fixed all conflicts, this became mostly a cleanup PR |
Hi Martin, I appreciate you taking the time to fix up the conflicts. However, as Joe mentioned, coincidentally I was finishing work in this same area recently, and ended up performing a similar combination of I'm sorry for stepping on your toes a bit here, that's largely my fault for not being as aware of your prior work in this area as I should have been 😕 With that in mind, this PR still has some nice doc comment additions and improvements, so I'm going to proceed with fixing up the conflicts and making sure that work is still incorporated. Thank you for all the work you've been doing cleaning up some of these warts in the standard library, it's not always the flashiest work, but very important for having a good foundation and keeping the stdlib healthy. My apologies again Martin 😌 |
!sync |
@martinvuyk do you mind rebasing this on top of @ConnorGray's recent changes in this area/the latest nightly? We'd love to incorporate the doc improvements here. Thanks! |
…-variadicpack-overload
@JoeLoser done |
Refactor
external_call()
and inline most of_LITRefPackHelper
intoVariadicPack
, leave_LITRefPackHelper
itself intact since I found no way to inline theAddressSpace
parameter intoVariadicPack
.