Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Refactor external_call() and inline _LITRefPackHelper into VariadicPack #3632

Open
wants to merge 29 commits into
base: nightly
Choose a base branch
from

Conversation

martinvuyk
Copy link
Contributor

@martinvuyk martinvuyk commented Oct 10, 2024

Refactor external_call() and inline most of _LITRefPackHelper into VariadicPack, leave _LITRefPackHelper itself intact since I found no way to inline the AddressSpace parameter into VariadicPack.

@martinvuyk martinvuyk marked this pull request as ready for review October 10, 2024 12:59
@martinvuyk martinvuyk requested a review from a team as a code owner October 10, 2024 12:59
Signed-off-by: martinvuyk <[email protected]>
…artinvuyk/mojo into add-externalcall-variadicpack-overload
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
Signed-off-by: martinvuyk <[email protected]>
stdlib/src/sys/ffi.mojo Outdated Show resolved Hide resolved
@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 11, 2024
@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 5, 2024

CC: @ConnorGray as you have an internal PR up for consolidating _LITRefPackHelper and VariadicPack from other work you were doing.

@ConnorGray
Copy link
Collaborator

!sync

@martinvuyk
Copy link
Contributor Author

@ConnorGray fixed all conflicts, this became mostly a cleanup PR

@ConnorGray
Copy link
Collaborator

ConnorGray commented Nov 7, 2024

Hi Martin, I appreciate you taking the time to fix up the conflicts. However, as Joe mentioned, coincidentally I was finishing work in this same area recently, and ended up performing a similar combination of _LITRefPackHelper and VariadicPack (with the addition that, with some advise from Chris L., we realized we could remove the address space parameter entirely for the time being, allowing a full removal of _LITRefPackHelper).

I'm sorry for stepping on your toes a bit here, that's largely my fault for not being as aware of your prior work in this area as I should have been 😕

With that in mind, this PR still has some nice doc comment additions and improvements, so I'm going to proceed with fixing up the conflicts and making sure that work is still incorporated.

Thank you for all the work you've been doing cleaning up some of these warts in the standard library, it's not always the flashiest work, but very important for having a good foundation and keeping the stdlib healthy. My apologies again Martin 😌

@ConnorGray
Copy link
Collaborator

!sync

@JoeLoser
Copy link
Collaborator

JoeLoser commented Nov 22, 2024

@martinvuyk do you mind rebasing this on top of @ConnorGray's recent changes in this area/the latest nightly? We'd love to incorporate the doc improvements here. Thanks!

@martinvuyk
Copy link
Contributor Author

@JoeLoser done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants