Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): error load remote should fire if before request throw #2373

Merged
merged 4 commits into from
Apr 29, 2024

Conversation

ScriptedAlchemy
Copy link
Member

Description

Error load remote should catch beforeRequest throws

Related Issue

#2371

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

@ScriptedAlchemy ScriptedAlchemy requested a review from 2heal1 April 24, 2024 21:00
Copy link

changeset-bot bot commented Apr 24, 2024

⚠️ No Changeset found

Latest commit: 8b0f1f9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 24, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 8b0f1f9
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/662efe9e7bae1f0008b17d8e
😎 Deploy Preview https://deploy-preview-2373--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy force-pushed the fix/error-load-remote-beforeReq branch from 43f5935 to bd56d74 Compare April 27, 2024 04:03
@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review April 29, 2024 01:57
@ScriptedAlchemy ScriptedAlchemy changed the title WIP fix: error load remote should fire if before request throw fix(runtime): error load remote should fire if before request throw Apr 29, 2024
@zhoushaw zhoushaw merged commit d08a9ba into main Apr 29, 2024
10 checks passed
@zhoushaw zhoushaw deleted the fix/error-load-remote-beforeReq branch April 29, 2024 02:55
@zhoushaw zhoushaw mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants