Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs-mf): delete duplicate code lines in nextjs-mf #2499

Merged
merged 3 commits into from
May 20, 2024
Merged

fix(nextjs-mf): delete duplicate code lines in nextjs-mf #2499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7d4ef20
fix(nextjs-mf): delete duplicate code lines in nextjs-mf
chussum May 16, 2024
88535f2
chore: run changeset
chussum May 16, 2024
5ff577f
Merge branch 'main' into fix/nextjs-duplicate-expose-logic
ScriptedAlchemy May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/poor-dots-confess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/nextjs-mf': patch
---

fix(nextjs-mf): delete duplicate code lines
2 changes: 1 addition & 1 deletion packages/nextjs-mf/src/plugins/NextFederationPlugin/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ export class NextFederationPlugin {
],
//@ts-ignore
exposes: {
...(this._extraOptions.skipSharingNextInternals ? {} : defaultExpose),
...defaultExpose,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should remain here. Users may want to disable sharing defaults in next.

Copy link
Contributor Author

@chussum chussum May 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScriptedAlchemy Isn't this redundant logic?
this._extraOptions.skipSharingNextInternals ?

https://github.com/module-federation/core/blob/main/packages/nextjs-mf/src/plugins/NextFederationPlugin/index.ts#L149-L156

스크린샷 2024-05-18 오전 9 08 45

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh i see, yes. ill appprove.

...this._options.exposes,
...(this._extraOptions.exposePages
? exposeNextjsPages(compiler.options.context as string)
Expand Down
Loading