Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs for @mf-types related errors #3090

Conversation

YanPes
Copy link
Contributor

@YanPes YanPes commented Oct 18, 2024

Description

Adding Error Catalog documentation for related open issues.
These issues were resolved via discussion but the results are good additions to the existing error catalog.

Related Issue

Please link to the issue here:
#2827
#2672

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

* Unable to use the **remote_name**'s "remote-origin/remoteEntry.js' URL with **remote_name**'s globalName to get remoteEntry exports.
* Unable to compile federated types, Error: compile TS failed
Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 4acf448

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Oct 18, 2024

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 4acf448
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/671897b3be959100088d707f
😎 Deploy Preview https://deploy-preview-3090--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@2heal1
Copy link
Member

2heal1 commented Oct 18, 2024

Thanks ! But i have one advice for setting loaded-first .

Now the shareStrategy can be set in build config , so no need to add runtime plugin .

https://module-federation.io/configure/shareStrategy.html

@YanPes
Copy link
Contributor Author

YanPes commented Oct 23, 2024

Did not know about the new addition to the build config. Nice config boost! Love it.
I'll update the PR today

* In the meantime the "shareStrategy" is part of the build config. Removed the runtimePlugin part of the doc and replaced it with the info on how to add the field to build-config.
@YanPes
Copy link
Contributor Author

YanPes commented Oct 23, 2024

PR updated @2heal1

@2heal1 2heal1 merged commit 7dcfa0c into module-federation:main Oct 23, 2024
14 checks passed
@YanPes YanPes deleted the docs/add-error-catalog-entries-for-mf-types branch October 23, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants