Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at implementing support for a PSR-3 logger into xPDO.
The basic idea is you pass a
LoggerInterface
into the container, which will then be set toprotected xPDO::$logger
(provided by theLoggerAwareTrait
).The new xPDOLogger is a BC layer that provides a PSR-3 implementation for the old behavior. This also deprecates most of the old logger stuff, so that could be removed in v4.
Some to do's:
For MODX-usage I'm thinking packages could provide a custom logger through the namespace
bootstrap.php
with setLogger(). Biggest challenge is that's after a bunch of other initialisation, including xPDO, so that might need some more thought.For testing so far I used a quick snippet: