invoices: if there are no invoices make gc noop

mohamedawnallah · Apr 30, 2024 · 1542424 · 1542424
1 parent e8a1d48
commit 1542424
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/channeldb/invoices.go b/channeldb/invoices.go
@@ -2139,14 +2139,14 @@ func (d *DB) DeleteCanceledInvoices(_ context.Context) error {
 			invoiceIndexBucket,
 		)
 		if invoiceIndex == nil {
-			return invpkg.ErrNoInvoicesCreated
+			return nil
 		}
 
 		invoiceAddIndex := invoices.NestedReadWriteBucket(
 			addIndexBucket,
 		)
 		if invoiceAddIndex == nil {
-			return invpkg.ErrNoInvoicesCreated
+			return nil
 		}
 
 		payAddrIndex := tx.ReadWriteBucket(payAddrIndexBucket)

diff --git a/invoices/invoices_test.go b/invoices/invoices_test.go
@@ -2681,8 +2681,11 @@ func testDeleteCanceledInvoices(t *testing.T,
 		}, nil
 	}
 
-	// Add some invoices to the test db.
+	// Test deletion of canceled invoices when there are none.
 	ctxb := context.Background()
+	require.NoError(t, db.DeleteCanceledInvoices(ctxb))
+
+	// Add some invoices to the test db.
 	var invoices []invpkg.Invoice
 	for i := 0; i < 10; i++ {
 		invoice, err := randInvoice(lnwire.MilliSatoshi(i + 1))