Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temp2 #14

Closed
wants to merge 21 commits into from
Closed

Temp2 #14

wants to merge 21 commits into from

Conversation

mohit-zangoh
Copy link
Owner

@mohit-zangoh mohit-zangoh commented Apr 15, 2024

Type

enhancement


Description

  • Added test functions (TestReviewdog_Run_clean_path, TestReviewdog_Run_returns_nil_if_fail_on_error_not_passed_and_some_errors_found, TestReviewdog_Run_returns_error_if_fail_on_error_passed_and_some_errors_found) and ExampleReviewdog function in reviewdog_test.go.
  • Added a workflow file (pr_agent.yml) for PR agent to run on specific events.
  • Added dev dependencies for textlint and eslint-formatter-sarif in package.json.

Changes walkthrough

Relevant files
Enhancement
reviewdog_test.go
Added test functions and ExampleReviewdog function             

reviewdog_test.go
['Added ExampleReviewdog function for testing Reviewdog functionality.', 'Added test functions for TestReviewdog_Run_clean_path, TestReviewdog_Run_returns_nil_if_fail_on_error_not_passed_and_some_errors_found, and TestReviewdog_Run_returns_error_if_fail_on_error_passed_and_some_errors_found.']

+174/-0 
pr_agent.yml
Added PR agent workflow file                                                         

.github/workflows/pr_agent.yml
['Added a workflow file for PR agent to run on specific events.']

+27/-0   
package.json
Added dev dependencies in package.json                                     

package.json
['Added dev dependencies for textlint and eslint-formatter-sarif.']

+10/-0   

PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

"fmt"
"sync"

"github.com/reviewdog/reviewdog/filter"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <compile> reported by reviewdog 🐶
no required module provides package github.com/reviewdog/reviewdog/filter; to add it:
go get github.com/reviewdog/reviewdog/filter

"sync"

"github.com/reviewdog/reviewdog/filter"
"github.com/reviewdog/reviewdog/proto/rdf"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <compile> reported by reviewdog 🐶
no required module provides package github.com/reviewdog/reviewdog/proto/rdf; to add it:
go get github.com/reviewdog/reviewdog/proto/rdf

"io"
"os"

"github.com/reviewdog/reviewdog/diff"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <compile> reported by reviewdog 🐶
no required module provides package github.com/reviewdog/reviewdog/diff; to add it:
go get github.com/reviewdog/reviewdog/diff


"github.com/reviewdog/reviewdog/diff"
"github.com/reviewdog/reviewdog/filter"
"github.com/reviewdog/reviewdog/parser"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [staticcheck] <compile> reported by reviewdog 🐶
no required module provides package github.com/reviewdog/reviewdog/parser; to add it:
go get github.com/reviewdog/reviewdog/parser

sm sync.Map
}

type Result struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint-pr-review] reported by reviewdog 🐶
exported type Result should have comment or be unexported

return l
}

type FilteredResult struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golint-pr-review] reported by reviewdog 🐶
exported type FilteredResult should have comment or be unexported

@github-actions github-actions bot added the enhancement New feature or request label Apr 15, 2024
Copy link

PR Description updated to latest commit (964fc8d)

Copy link

PR Review

⏱️ Estimated effort to review [1-5]

2, because the changes are well-segmented and focused, making it easier to review.

🧪 Relevant tests

Yes

🔍 Possible issues

No

🔒 Security concerns

No

Code feedback:
relevant fileerror_example.py
suggestion      

Consider fixing the syntax and linting errors in the added code. For example:

  • Add a colon after the def greet(name) function definition.
  • Fix the missing closing parenthesis in the print("This will cause a syntax error" # missing closing parenthesis line.
  • Add a colon after the def my_function(): function definition.
  • Correct the missing colon in the if x == 10 statement.
relevant linedef greet(name)


✨ Review tool usage guide:

Overview:
The review tool scans the PR code changes, and generates a PR review which includes several types of feedbacks, such as possible PR issues, security threats and relevant test in the PR. More feedbacks can be added by configuring the tool.

The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on any PR.

  • When commenting, to edit configurations related to the review tool (pr_reviewer section), use the following template:
/review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=...
[pr_reviewer]
some_config1=...
some_config2=...

See the review usage page for a comprehensive guide on using this tool.

Copy link

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants