Update MATSim CW30

contribs/application/src/main/java/org/matsim/freightDemandGeneration/DemandReaderFromCSV.java

@@ -667,18 +667,25 @@ else if (samplingOption.equals("changeDemandOnLocation")) {
 					int demandForThisLink = calculateDemandBasedOnLinkLength(countOfLinks, distributedDemand, demandToDistribute, possibleLinksForService.size(),
 						sumOfPossibleLinkLength, link);
 					countOfLinks++;
-					double serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit()
-							* demandForThisLink;
-					Id<CarrierService> idNewService = Id.create(
+					Carrier thisCarrier = CarriersUtils.getCarriers(scenario).getCarriers()
+							.get(Id.create(newDemandInformationElement.getCarrierName(), Carrier.class));
+					int numberOfJobsForDemand = calculateNumberOfJobsForDemand(thisCarrier, demandForThisLink);
+					for (int i = 0; i < numberOfJobsForDemand; i++) {
+						int singleDemandForThisLink = demandForThisLink / numberOfJobsForDemand;
+						if (i == numberOfJobsForDemand - 1)
+							singleDemandForThisLink = demandForThisLink - (numberOfJobsForDemand - 1) * singleDemandForThisLink;
+						double serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit()
+							* singleDemandForThisLink;
+						Id<CarrierService> idNewService = Id.create(
 							createJobId(scenario, newDemandInformationElement, link.getId(), null),
 							CarrierService.class);
-					if (demandToDistribute > 0 && demandForThisLink > 0) {
-						CarrierService thisService = CarrierService.Builder.newInstance(idNewService, link.getId())
-								.setCapacityDemand(demandForThisLink).setServiceDuration(serviceTime)
+						if (demandToDistribute > 0 && singleDemandForThisLink > 0) {
+							CarrierService thisService = CarrierService.Builder.newInstance(idNewService, link.getId())
+								.setCapacityDemand(singleDemandForThisLink).setServiceDuration(serviceTime)
 								.setServiceStartTimeWindow(newDemandInformationElement.getFirstJobElementTimeWindow())
 								.build();
-						CarriersUtils.getCarriers(scenario).getCarriers().values().iterator().next().getServices()
-								.put(thisService.getId(), thisService);
+							thisCarrier.getServices().put(thisService.getId(), thisService);
+						}
 					}
 					distributedDemand = distributedDemand + demandForThisLink;
 				}
@@ -706,23 +713,31 @@ else if (samplingOption.equals("changeDemandOnLocation")) {
 				}
 				int demandForThisLink = calculateDemandForThisLink(demandToDistribute, numberOfJobs, distributedDemand, i);
 
-				double serviceTime;
-				if (demandToDistribute == 0)
-					serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit();
-				else
-					serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit() * demandForThisLink;
-				usedServiceLocations.add(link.getId().toString());
+				Carrier thisCarrier = CarriersUtils.getCarriers(scenario).getCarriers()
+					.get(Id.create(newDemandInformationElement.getCarrierName(), Carrier.class));
+				int numberOfJobsForDemand = calculateNumberOfJobsForDemand(thisCarrier, demandForThisLink);
+				for (int j = 0; j < numberOfJobsForDemand; j++) {
+					int singleDemandForThisLink = demandForThisLink / numberOfJobsForDemand;
+					if (j == numberOfJobsForDemand - 1)
+						singleDemandForThisLink = demandForThisLink - (numberOfJobsForDemand - 1) * singleDemandForThisLink;
+					double serviceTime;
+					if (singleDemandForThisLink == 0)
+						serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit();
+					else
+						serviceTime = newDemandInformationElement.getFirstJobElementTimePerUnit() * demandForThisLink;
+					usedServiceLocations.add(link.getId().toString());
 
-				Id<CarrierService> idNewService = Id.create(
+					Id<CarrierService> idNewService = Id.create(
 						createJobId(scenario, newDemandInformationElement, link.getId(), null), CarrierService.class);
-				if ((demandToDistribute > 0 && demandForThisLink > 0) || demandToDistribute == 0) {
-					CarrierService thisService = CarrierService.Builder.newInstance(idNewService, link.getId())
-							.setCapacityDemand(demandForThisLink).setServiceDuration(serviceTime)
+					if ((demandToDistribute > 0 && singleDemandForThisLink > 0) || demandToDistribute == 0) {
+						CarrierService thisService = CarrierService.Builder.newInstance(idNewService, link.getId())
+							.setCapacityDemand(singleDemandForThisLink).setServiceDuration(serviceTime)
 							.setServiceStartTimeWindow(newDemandInformationElement.getFirstJobElementTimeWindow())
 							.build();
-					CarriersUtils.getCarriers(scenario).getCarriers()
+						CarriersUtils.getCarriers(scenario).getCarriers()
 							.get(Id.create(newDemandInformationElement.getCarrierName(), Carrier.class)).getServices()
 							.put(thisService.getId(), thisService);
+					}
 				}
 				distributedDemand = distributedDemand + demandForThisLink;
 			}
@@ -1007,29 +1022,56 @@ else if (numberOfPickupLocations != null) {
 	private static void createSingleShipment(Scenario scenario, DemandInformationElement newDemandInformationElement,
 											 Link linkPickup, Link linkDelivery, int demandForThisLink) {
 
-		Id<CarrierShipment> idNewShipment = Id.create(createJobId(scenario, newDemandInformationElement,
-			linkPickup.getId(), linkDelivery.getId()), CarrierShipment.class);
+		Carrier thisCarrier = CarriersUtils.getCarriers(scenario).getCarriers()
+			.get(Id.create(newDemandInformationElement.getCarrierName(), Carrier.class));
+		int numberOfJobsForDemand = calculateNumberOfJobsForDemand(thisCarrier, demandForThisLink);
 
 		TimeWindow timeWindowPickup = newDemandInformationElement.getFirstJobElementTimeWindow();
 		TimeWindow timeWindowDelivery = newDemandInformationElement.getSecondJobElementTimeWindow();
 
-		double serviceTimePickup;
-		double serviceTimeDelivery;
-		if (demandForThisLink == 0) {
-			serviceTimePickup = newDemandInformationElement.getFirstJobElementTimePerUnit();
-			serviceTimeDelivery = newDemandInformationElement.getSecondJobElementTimePerUnit();
-		} else {
-			serviceTimePickup = newDemandInformationElement.getFirstJobElementTimePerUnit() * demandForThisLink;
-			serviceTimeDelivery = newDemandInformationElement.getSecondJobElementTimePerUnit() * demandForThisLink;
+		for (int i = 0; i < numberOfJobsForDemand; i++) {
+			Id<CarrierShipment> idNewShipment = Id.create(createJobId(scenario, newDemandInformationElement,
+				linkPickup.getId(), linkDelivery.getId()), CarrierShipment.class);
+			double serviceTimePickup;
+			double serviceTimeDelivery;
+			int singleDemandForThisLink = Math.round ((float) demandForThisLink / numberOfJobsForDemand);
+			if (i == numberOfJobsForDemand - 1)
+				singleDemandForThisLink = demandForThisLink - (numberOfJobsForDemand - 1) * singleDemandForThisLink;
+			if (singleDemandForThisLink == 0) {
+				serviceTimePickup = newDemandInformationElement.getFirstJobElementTimePerUnit();
+				serviceTimeDelivery = newDemandInformationElement.getSecondJobElementTimePerUnit();
+			} else {
+				serviceTimePickup = newDemandInformationElement.getFirstJobElementTimePerUnit() * singleDemandForThisLink;
+				serviceTimeDelivery = newDemandInformationElement.getSecondJobElementTimePerUnit() * singleDemandForThisLink;
+			}
+			CarrierShipment thisShipment = CarrierShipment.Builder
+				.newInstance(idNewShipment, linkPickup.getId(), linkDelivery.getId(), singleDemandForThisLink)
+				.setPickupServiceTime(serviceTimePickup).setPickupTimeWindow(timeWindowPickup)
+				.setDeliveryServiceTime(serviceTimeDelivery).setDeliveryTimeWindow(timeWindowDelivery)
+				.build();
+			thisCarrier.getShipments().put(thisShipment.getId(), thisShipment);
+		}
+	}
+
+	/**
+	 * Method calculates the number of jobs for a demand on one link based on the largest vehicle capacity of the carrier.
+	 *
+	 * @param thisCarrier       the carrier of a job
+	 * @param demandForThisLink Demand for this link
+	 * @return Number of jobs for this demand
+	 */
+	private static int calculateNumberOfJobsForDemand(Carrier thisCarrier, int demandForThisLink) {
+		double largestVehicleCapacity = 0;
+		for (CarrierVehicle vehicle : thisCarrier.getCarrierCapabilities().getCarrierVehicles().values()) {
+			if (vehicle.getType().getCapacity().getOther() > largestVehicleCapacity) {
+				largestVehicleCapacity = vehicle.getType().getCapacity().getOther();
+			}
+		}
+		if (demandForThisLink > largestVehicleCapacity) {
+			log.info("Demand {} is larger than the largest vehicle capacity ({}). Splitting demand into multiple jobs.", demandForThisLink, largestVehicleCapacity);
+			return (int) Math.ceil((double) demandForThisLink / largestVehicleCapacity);
 		}
-		CarrierShipment thisShipment = CarrierShipment.Builder
-			.newInstance(idNewShipment, linkPickup.getId(), linkDelivery.getId(), demandForThisLink)
-			.setPickupServiceTime(serviceTimePickup).setPickupTimeWindow(timeWindowPickup)
-			.setDeliveryServiceTime(serviceTimeDelivery).setDeliveryTimeWindow(timeWindowDelivery)
-			.build();
-		CarriersUtils.getCarriers(scenario).getCarriers()
-			.get(Id.create(newDemandInformationElement.getCarrierName(), Carrier.class)).getShipments()
-			.put(thisShipment.getId(), thisShipment);
+		return 1;
 	}
 
 	/**
@@ -1086,7 +1128,7 @@ private static int calculateDemandForThisLink(int demandToDistribute, int number
 		} else {
 			roundingError = roundingError
 				+ ((double) demandForThisLink - ((double) demandToDistribute / (double) numberOfJobs));
-			if (roundingError > 1) {
+			if (roundingError >= 1) {
 				demandForThisLink = demandForThisLink - 1;
 				roundingError = roundingError - 1;
 			}
@@ -1113,7 +1155,7 @@ private static int calculateDemandBasedOnLinkLength(int countOfLinks, int distri
 				.ceil(link.getLength() / sumOfPossibleLinkLength * (double) demandToDistribute);
 			roundingError = roundingError + ((double) demandForThisLink
 				- (link.getLength() / sumOfPossibleLinkLength * (double) demandToDistribute));
-			if (roundingError > 1) {
+			if (roundingError >= 1) {
 				demandForThisLink = demandForThisLink - 1;
 				roundingError = roundingError - 1;
 			}
@@ -1265,7 +1307,7 @@ private static HashMap<Id<Link>, Link> findAllPossibleLinks(Scenario scenario,
 						crsTransformationNetworkAndShape);
 				if (!possibleLinks.containsKey(newPossibleLink.getId()))
 					possibleLinks.put(newPossibleLink.getId(), newPossibleLink);
-				if (nearestLinkPerPerson.size() == possiblePersons.size())
+				if (!possiblePersons.isEmpty() && nearestLinkPerPerson.size() == possiblePersons.size())
 					break;
 			}
 		}

contribs/application/src/main/java/org/matsim/freightDemandGeneration/FreightDemandGeneration.java

@@ -381,6 +381,13 @@ private void createDemand(DemandGenerationOptions selectedDemandGenerationOption
 						 */
 							FreightDemandGenerationUtils.preparePopulation(population, sampleSizeInputPopulation,
 									upSamplePopulationTo, "changeDemandOnLocation");
+					case noPopulationSampling ->
+						/*
+						 * If the demand sample is equal to the population sample, the demand is created
+						 * based on the given population and the set input population sampleSize
+						 */
+							FreightDemandGenerationUtils.preparePopulation(population, sampleSizeInputPopulation,
+								sampleSizeInputPopulation, "noPopulationSampling");
 					default -> throw new RuntimeException("No valid sampling option selected!");
 				}
 				switch (selectedPopulationOption) {

contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/dashboards/DrtDashboard.java

@@ -159,7 +159,7 @@ public void configure(Header header, Layout layout) {
 				viz.description = "Number of rides (customers) is displayed in bars, wait statistics in lines";
 
 				Plotly.DataSet waitStats = viz.addDataset(data.output("*_waitStats_" + drtConfigGroup.mode + ".csv"));
-				Plotly.DataSet rejections = viz.addDataset(data.output("*drt_rejections_perTimeBin_" +  drtConfigGroup.mode + ".csv"));
+				Plotly.DataSet rejections = viz.addDataset(data.output("*drt_rejections_perTimeBin_" + drtConfigGroup.mode + ".csv"));
 
 				viz.layout = tech.tablesaw.plotly.components.Layout.builder()
 					.xAxis(Axis.builder().title("Time Bin").build())
@@ -244,7 +244,7 @@ public void configure(Header header, Layout layout) {
 
 					viz.layout = tech.tablesaw.plotly.components.Layout.builder()
 						.xAxis(Axis.builder().title("Iteration").build())
-						.yAxis(Axis.builder().title("Wait Time [s]").build())
+						.yAxis(Axis.builder().title("Number of Rides").build())
 						.barMode(tech.tablesaw.plotly.components.Layout.BarMode.STACK)
 						.build();
 
@@ -272,12 +272,12 @@ public void configure(Header header, Layout layout) {
 					viz.description = "";
 					viz.dataset = data.output("*customer_stats_" + drtConfigGroup.mode + ".csv");
 					viz.x = "iteration";
-					viz.columns = List.of("wait_average","wait_median", "wait_p95");
+					viz.columns = List.of("wait_average", "wait_median", "wait_p95");
 					viz.legendName = List.of("Average", "Median", "95th Percentile");
 					viz.xAxisName = "Iteration";
 					viz.yAxisName = "Waiting Time [s]";
 				})
-				;
+			;
 
 			layout.row("Demand And Travel Time Statistics per iteration")
 				.el(Plotly.class, (viz, data) -> {

contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/edrt/run/EDrtControlerCreator.java

@@ -41,11 +41,13 @@
 public class EDrtControlerCreator {
 
 	public static Controler createControler(Config config, boolean otfvis) {
-		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
-		DrtConfigs.adjustMultiModeDrtConfig(multiModeDrtConfig, config.scoring(), config.routing());
-
 		Scenario scenario = DrtControlerCreator.createScenarioWithDrtRouteFactory(config);
 		ScenarioUtils.loadScenario(scenario);
+		return createControler(config, scenario, otfvis);
+	}
+	public static Controler createControler(Config config, Scenario scenario, boolean otfvis) {
+		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
+		DrtConfigs.adjustMultiModeDrtConfig(multiModeDrtConfig, config.scoring(), config.routing());
 
 		Controler controler = new Controler(scenario);
 		controler.addOverridingModule(new MultiModeEDrtModule());

contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/operations/DrtOperationsControlerCreator.java

@@ -1,5 +1,7 @@
 package org.matsim.contrib.drt.extension.operations;
 
+import org.matsim.api.core.v01.Scenario;
+import org.matsim.contrib.drt.extension.DrtWithExtensionsConfigGroup;
 import org.matsim.contrib.drt.extension.operations.operationFacilities.OperationFacilitiesModeModule;
 import org.matsim.contrib.drt.extension.operations.operationFacilities.OperationFacilitiesQSimModule;
 import org.matsim.contrib.drt.extension.operations.shifts.analysis.efficiency.DrtShiftEfficiencyModeModule;
@@ -26,20 +28,34 @@ public class DrtOperationsControlerCreator {
 	 * @return
 	 */
 	public static Controler createControler(Config config, boolean otfvis) {
-		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
-
 		Controler controler = DrtControlerCreator.createControler(config, otfvis);
+		return prepareController(config, controler);
+	}
+
+	/**
+	 * Creates a controller in one step.
+	 *
+	 * @param config
+	 * @param scenario
+	 * @param otfvis
+	 * @return
+	 */
+	public static Controler createControler(Config config, Scenario scenario, boolean otfvis) {
+		Controler controler = DrtControlerCreator.createControler(config, scenario, otfvis);
+		return prepareController(config, controler);
+	}
 
+	private static Controler prepareController(Config config, Controler controler) {
+		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
 		for (DrtConfigGroup drtCfg : multiModeDrtConfig.getModalElements()) {
 			controler.addOverridingModule(new ShiftDrtModeModule(drtCfg));
 			controler.addOverridingQSimModule(new DrtModeQSimModule(drtCfg, new ShiftDrtModeOptimizerQSimModule(drtCfg)));
-			controler.addOverridingModule(new OperationFacilitiesModeModule((DrtWithOperationsConfigGroup) drtCfg));
+			controler.addOverridingModule(new OperationFacilitiesModeModule((DrtWithExtensionsConfigGroup) drtCfg));
 			controler.addOverridingQSimModule(new OperationFacilitiesQSimModule(drtCfg));
 			controler.addOverridingModule(new DrtShiftEfficiencyModeModule(drtCfg));
 		}
 
 		controler.configureQSimComponents(DvrpQSimComponents.activateAllModes(multiModeDrtConfig));
-
 		return controler;
 	}
 }

contribs/drt-extensions/src/main/java/org/matsim/contrib/drt/extension/operations/EDrtOperationsControlerCreator.java

@@ -1,5 +1,7 @@
 package org.matsim.contrib.drt.extension.operations;
 
+import org.matsim.api.core.v01.Scenario;
+import org.matsim.contrib.drt.extension.DrtWithExtensionsConfigGroup;
 import org.matsim.contrib.drt.extension.edrt.run.EDrtControlerCreator;
 import org.matsim.contrib.drt.extension.operations.eshifts.charging.ShiftOperatingVehicleProvider;
 import org.matsim.contrib.drt.extension.operations.eshifts.fleet.EvShiftDvrpFleetQSimModule;
@@ -23,29 +25,34 @@
 public class EDrtOperationsControlerCreator {
 
 	public static Controler createControler(Config config, boolean otfvis) {
-
-		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
-
 		Controler controler = EDrtControlerCreator.createControler(config, otfvis);
+		prepareController(config, controler);
+		return controler;
+	}
+
+	public static Controler createControler(Config config, Scenario scenario, boolean otfvis) {
+		Controler controler = EDrtControlerCreator.createControler(config, scenario, otfvis);
+		prepareController(config, controler);
+		return controler;
+	}
 
+	private static void prepareController(Config config, Controler controler) {
+		MultiModeDrtConfigGroup multiModeDrtConfig = MultiModeDrtConfigGroup.get(config);
 		for (DrtConfigGroup drtCfg : multiModeDrtConfig.getModalElements()) {
 			controler.addOverridingModule(new ShiftDrtModeModule(drtCfg));
 			controler.addOverridingQSimModule(new DrtModeQSimModule(drtCfg, new ShiftDrtModeOptimizerQSimModule(drtCfg)));
 			controler.addOverridingQSimModule(new ShiftEDrtModeOptimizerQSimModule(drtCfg));
 			controler.addOverridingQSimModule(new EvShiftDvrpFleetQSimModule(drtCfg.getMode()));
-			controler.addOverridingModule(new OperationFacilitiesModeModule((DrtWithOperationsConfigGroup) drtCfg));
+			controler.addOverridingModule(new OperationFacilitiesModeModule((DrtWithExtensionsConfigGroup) drtCfg));
 			controler.addOverridingQSimModule(new OperationFacilitiesQSimModule(drtCfg));
 			controler.addOverridingModule(new DrtShiftEfficiencyModeModule(drtCfg));
 		}
 
-
 		controler.addOverridingQSimModule(new AbstractQSimModule() {
 			@Override
 			protected void configureQSim() {
 				this.bind(IdleDischargingHandler.VehicleProvider.class).to(ShiftOperatingVehicleProvider.class);
 			}
 		});
-
-		return controler;
 	}
 }