Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MATSim CW35 #112

Merged
merged 45 commits into from
Aug 29, 2024
Merged

Update MATSim CW35 #112

merged 45 commits into from
Aug 29, 2024

Conversation

nkuehnel
Copy link
Member

  • Score explanation functionality
  • copy analysis code from matsim-kelheim to application contrib
  • rename a method from add... to set... since that is what is does.
  • changes
  • update config group
  • update tests and added attributes
  • fix un initialized attribute
  • small improvement to object creation
  • add leg score for individual legs
  • more consistent naming
  • more consistent naming
  • revert unintentional changes
  • CreateDrtDashboard
  • Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.2.5 to 3.3.0
  • rename pooling ratio to occupancy rate
  • account for group bookings in DrtAnalysisPostProcessing (and thus DrtDashboard)
  • typo in CreateDrtDashboard
  • fix wrong sum calculation
  • debug NoiseAnalysis and proper testing in NoiseDashboardTests
  • fix wrong map selection
  • add reduction of numberOfJobs
  • add comments and format log massages
  • combine
  • rename parameter
  • reduce code
  • format logging
  • use method for demand calculating
  • use method for shipment creation
  • remove todo
  • use method to calculate demand based on link lengths
  • introduce parameter
  • simplify
  • cleanup
  • Support TransitRouteStops where boarding or alighting is not allowed
  • make drt shifts multi mode drt comatible
  • adjust shift efficiency tracker as well
  • Extended Trip analysis and dashboard (Extended Trip analysis and dashboard matsim-org/matsim-libs#3332)
  • Bump org.apache.maven.plugins:maven-surefire-plugin from 3.2.5 to 3.3.0
  • Bump org.apache.maven.plugins:maven-surefire-report-plugin
  • Bump org.apache.maven.plugins:maven-jar-plugin from 3.4.1 to 3.4.2
  • Bump com.fasterxml.woodstox:woodstox-core from 6.6.2 to 7.0.0
  • Bump org.jfree:jfreechart from 1.5.4 to 1.5.5
  • make drt work with only custom constraints sets
  • add some logging to NetworkChangeEventsWriter
  • correct logging statement
  • add router binding for complex request unscheduling
  • use time as disutility
  • Bump junit.version from 5.10.2 to 5.10.3
  • *** repair wrong positioning of vehicles if linkSpeedCalculator returns speed larger than free speed * replace some (but not all) link.getAttributes()... by BicycleUtils.set/getXyz( link, ...) * bind BicycleConfigGroup explicitly in BicycleModule so that not materializing it before does not lead to a non-interpretable error message (stating that Scenario is not bound about 20 times although that is not the root of the problem) * possibly one or the other additional things**
  • norm subgroups to 1 (Norm mode shares in TripAnalysis matsim-org/matsim-libs#3346)
  • add tests for mode restriction
  • add test integration test case for complex unscheduler
  • Bump io.grpc:grpc-all from 1.64.0 to 1.65.0
  • add tests that depict the current behaviour
  • Bump com.google.protobuf:protobuf-java from 4.27.1 to 4.27.2
  • implement multiple mode test
  • Split CalculateSkimMatrices.prepareAndCalculateNetworkMatrices() to allow for custom travel times objects
  • implement option for network inconsistency check; no test adaptation so far
  • Bump org.checkerframework:checker-qual from 3.44.0 to 3.45.0
  • implemented network changer
  • implement functionality in Util classes and moved config
  • implement test using the new functionality for mode restriction
  • revert changing the default access egress type
  • Switch to DrtWithExtensionsConfigGroup
  • Bump org.apache.poi:poi-ooxml from 5.2.5 to 5.3.0
  • explicitly set access egress type
  • fix test failures in contribs
  • fix test failures in contribs and add config parameter so relevant functions
  • reworked CreatePseudoNetwork with loop-links to avoid duplicating stops
  • repair test failures
  • Trip facet dashboard (Trip facet dashboard matsim-org/matsim-libs#3350)
  • adjust rounding
  • exclude case
  • Drt dashboard typo fix (Drt dashboard typo fix matsim-org/matsim-libs#3360)
  • Bump com.fasterxml.jackson:jackson-bom from 2.17.1 to 2.17.2
  • Bump net.bytebuddy:byte-buddy from 1.14.17 to 1.14.18
  • set networkMode based on vehicleTypes
  • pass lambda function as parameter
  • Bump org.assertj:assertj-core from 3.26.0 to 3.26.3
  • chore: clean up MinimalTransferTimes (chore: clean up MinimalTransferTimes matsim-org/matsim-libs#3365)
  • chore: cleanup adaptive transfers (chore: cleanup adaptive transfers matsim-org/matsim-libs#3366)
  • Bump org.apache.maven.plugins:maven-failsafe-plugin from 3.3.0 to 3.3.1
  • add missing case of enum
  • add functionality to split jobs
  • use new methods
  • update activity creation
  • set activity time correctly
  • remove unneeded exception
  • change to parameterized log message
  • delete empty test methods
  • remove unused import
  • fix unchecked assignment
  • remove redundant local variables
  • minor code style update
  • remove not needed throw information
  • make things final
  • remove redundant final declaration
  • remove unnecessary 'throws' declarations
  • simplify assertions
  • cleanup Strings
  • remove redundant casts
  • code style update
  • cleanup imports
  • Java language: Replace explicit type with <>
  • Java language: use computeIfAbsent
  • Java language: use Double.hashCode(...)
  • Java language: replace if by switch
  • Java language: avoid raw use
  • Java language: use text block
  • Java language: use pattern variable
  • Java language: use add/getFirst()
  • Access to TestUtils.EPSILION
  • add not null assertion
  • remove one layer of "LSPs"
  • add prebooking support for drt shifts some minor shift cleanups possibility to assign requests to shifts that are assigned bot not started yet
  • cancel assigned shifts
  • Bump com.google.errorprone:error_prone_annotations from 2.28.0 to 2.29.2
  • add some documentation
  • shift drt maintenance
  • some more drt shift maintenance
  • consider break corridors for (pre)bookings
  • consider break corridors for (pre)bookings
  • clean up obsolete method
  • update FISS test, reduce iterations to reduce runtime
  • avoid abandoning prebooked requests twice in the same time step
  • fix tests by disabling net consistency check
  • adapt error messages
  • remove redundant suppression
  • remove unused field
  • internal renaming
  • remove unnecessary toString() calls
  • remove unnecessary semicolon
  • inline and remove method
  • cleanup imports
  • simplification
  • make final, internal renaming
  • replace 'if' by 'switch'
  • simplification
  • use enhanced 'switch'
  • simplification
  • use 'getFirst()'
  • javadoc: replace blank lines with '

    '

  • javadoc: set link as a link
  • logging: use parameterized logging
  • add casting
  • simplification
  • use 'append()' calls
  • simplification by removing inaccessibly parts of if statements.
  • remove duplicated setting of variable
  • Simplify assertions
  • Simplify stream
  • avoid casting
  • suppress warning
  • fix some (language) grammar
  • fix some typos
  • more simplifications
  • cleanup: remove commented out code
  • small cleanups
  • fix test failures by disable net consistency check
  • optimize h3 zone system initialization; move h3 test to common module
  • shift drt maintenance; fix bug for prebooked e-drt scenarios that need shifts to be assignable to requests in advance; change priority queues in shift dispatcher to sorted sets to ensure correct iteration order
  • make FISS integration test less sensible to smaller changes in link events
  • set level of some logging's back from WARN to DEBUG
  • SimWrapper Dashboard features (SimWrapper Dashboard features matsim-org/matsim-libs#3381)
  • Update GenerateFreightPlans.java (Update GenerateFreightPlans.java matsim-org/matsim-libs#3387)
  • add events files comparison
  • more (javadoc) comments
  • add test which includes tolling. One test is failing, because it is not possible to create different schemes for the different types.
  • WIP: Prepare test for tolling with factor. Not implemented to the end now -> Disabled.
  • replace self-build RoadPricingCalculator with official RoadPricingScheme
  • adapt test: use tollFactor
  • add option if person==null
  • more tests
  • more steps forward
  • fix one test: Use MATSim's vehicles
  • fix the last test: Building the netbased costs without MATSim's vehicle types
  • some cleanup and javadoc
  • fix typos, internal renaming
  • Bump org.apache.maven.plugins:maven-surefire-report-plugin
  • Bump io.grpc:grpc-all from 1.65.0 to 1.65.1
  • Bump org.apache.maven.plugins:maven-surefire-plugin from 3.3.0 to 3.3.1
  • Bump commons-codec:commons-codec from 1.17.0 to 1.17.1
  • Bump it.unimi.dsi:fastutil-core from 8.5.13 to 8.5.14
  • Bump geotools.version from 31.2 to 31.3
  • Preserve the working directory when gui is run from cli (Preserve the working directory when gui is run from cli matsim-org/matsim-libs#3391)
  • use asterisk for act type default
  • NoiseAnalysis: set the scale factor for according to sample size
  • add fare zone based pt pricing (add fare zone based pt pricing matsim-org/matsim-libs#3382)
  • better defaults for NoiseDashboard
  • remove the static
  • NoiseAnalysis: more explicit parameter settings + bug fix in MergeNoiseOutput
  • Update DRT estimate and teleport module (Update DRT estimate and teleport module matsim-org/matsim-libs#3333)
  • NoiseAnalysis: merge damages files
  • NoiseDashboard: include stats and damage plots
  • only perform net consistency check once
  • CreateSingleSimWrapperDashboard
  • fix noise tests: explicitly set activity types for rp grid, when setting act type for damage calculation
  • add simple way of rejecting request insertion offers by the customer
  • update test
  • fix nasty insertion scheduler bug
  • Bump org.hamcrest:hamcrest from 2.2 to 3.0
  • Accept optional OD pairs in route validation (Accept optional OD pairs in route validation matsim-org/matsim-libs#3409)
  • add ride scoring parametrization based on car (add ride scoring parametrization based on car matsim-org/matsim-libs#3410)
  • add chained pt fare handler
  • implemented tests
  • implemented integration test
  • Pt distance class fares (Pt distance class fares matsim-org/matsim-libs#3413)
  • Pt fares minor cleanup (Pt fares minor cleanup matsim-org/matsim-libs#3414)
  • add designated vehicle for shifts
  • actually use designated vehicle in assignment
  • tourStartTime is always set to 0, which can lead to the end time of a tour being earlier than the start time of the tour... this is fixed now
  • drt shift designated vehicle fix
  • avoid deadlock situations with undercharged vehicles at hubs
  • update (e)shift task schedulers
  • update (e)shift task schedulers
  • dump shifts after each iteration
  • some updates to drt shifts
  • Bypass Fleet object in schedule interface
  • remove static
  • add comment
  • fix activity creation
  • add comments
  • update test
  • use getFirst
  • rename
  • deprecate methods
  • Fix pt fare config write to and read from config file (Fix pt fare config write to and read from config file matsim-org/matsim-libs#3427)
  • use EnumeratedDistribution instead of own class
  • move tour specifications to separate class
  • add comment
  • fix import
  • Pt fares extended tests, check distance classes have distinct max distances (Pt fares extended tests, check distance classes have distinct max distances matsim-org/matsim-libs#3428)
  • use getFirst
  • add variable for legMode for extracted plans
  • pt fares interpret file paths to fare zone shapes relative to config file (pt fares interpret file paths to fare zone shapes relative to config file matsim-org/matsim-libs#3430)
  • fix rare insertion bug add test case for insertion scheduler
  • drt: add option to prevent agents re-attempting to book a rejected pre-booked ride
  • correct german wide fare km / m conversion, add check fare != null in FareZoneBasedPtFareCalculator (correct german wide fare km / m conversion, add check fare != null matsim-org/matsim-libs#3434)
  • update tests
  • update test

simei94 and others added 30 commits August 19, 2024 17:57
… tour being earlier than the start time of the tour... this is fixed now
drt shifts: avoid deadlock situations with undercharged vehicles at hubs
DRT: Bypass Fleet object in schedule interface
* adapt test to test writing PtFareConfigGroup to file and read in again.

* fix write and read ptFareConfigGroup
…affic-generation' into bugfix-small-scale-commercial-traffic-generation
…-commercial-traffic-generation

- fix Bug with commercial plan generation (Tour start time, activity durations and tour end time) and adjust test
- remove static
- move tour characteristic data to separate class
- use only EnumeratedDistribution instead of own implementation
…tances (matsim-org#3428)

* rename and extend test for ChainedPtFareHandlerTest

* hopefully more efficient distance to distance class fare params lookup

* ensure distinct max distances in distance class fare params, set default minFare to 0
@mfrawley-moia mfrawley-moia merged commit 8b61506 into moia-deployment Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants