-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mojaloop/3050): implemented settlement model rules engine (#934) #942
Draft
mdebarros
wants to merge
17
commits into
main
Choose a base branch
from
feat/#3048-poc-settlement-model-rules-engine
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: implemented settlement model rules engine * chore: removed commented code
…ssages (#936) * feat: add option to include decoded transaction in messages * chore: test * chore: audit * chore: remove * chore: fix dep breaking test * is this really a dep failure? * cleanup * yep, which dep is it * potentially knex migration and seeding issue! * chore: add explanation and error message log * chore: remove unneeded stringify
…enarios (#937) * feat(mojaloop/#3080): add validator for ilpPacket and unhappy test scenarios * chore: update int tests * chore: lint * revert * chore: move code
* feat: implemented settlement model rules engine * chore: removed commented code * feat: initial changes * feat: refactor rule engine integration * feat: refactor the rules engine * chore: move rule/decode logic and refactor transfer save * fix: payer limit issue in integration tests * fix: lint issues and integration tests * chore: changed default value for settlement model * fix: issue-with-failed-transfers * fix: unit test * fix: transferStateAndPositionUpdate * fix: some fixes * fix: settlement model chache issue * fix: lint issues * chore(snapshot): 16.4.0-snapshot.0 * chore(snapshot): 16.4.0-snapshot.1 * fix: build step for snapshot releases * chore(snapshot): 16.4.0-snapshot.2 * fix: settlement model rules engine default issue * chore(snapshot): 16.4.0-snapshot.3 * chore: improve coverage * fix: integration tests * chore: removed console log * chore: updated dependencies * fix: lint issues * fix: audi issue * fix: added missing param to config file * fix: removed INCLUDE_DECODED_TRANSACTION_OBJECT * fix: lint --------- Co-authored-by: Kevin <[email protected]>
Vijay Kumar seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Quality Gate failedFailed conditions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: implemented settlement model rules engine
chore: removed commented code