PIPRES-468 "Title" multilanguage functionality #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GytisZum
reviewed
Nov 25, 2024
| $this->context = $context; | ||
| } | ||
|
|
||
| public function savePaymentTitleTranslation(string $idPaymentMethod, int $langId, string $translation, int $idShop) |
GytisZum
reviewed
Nov 27, 2024
| @@ -104,10 +107,22 @@ public function getPaymentOption(MolPaymentMethod $paymentMethod): PaymentOption | |||
| { | |||
| $paymentOption = new PaymentOption(); | |||
|
|
|||
| /** @var Context $shopContext */ | |||
| $shopContext = $this->module->getService(Context::class); | |||
There was a problem hiding this comment.
$context not shop context
GytisZum
reviewed
Nov 27, 2024
| @@ -128,10 +130,23 @@ public function __construct( | |||
| public function getPaymentOption(MolPaymentMethod $paymentMethod): PaymentOption | |||
| { | |||
| $paymentOption = new PaymentOption(); | |||
|
|
|||
| /** @var Context $shopContext */ | |||
| $shopContext = $this->module->getService(Context::class); | |||
GytisZum
reviewed
Nov 27, 2024
| @@ -126,10 +128,22 @@ public function getPaymentOption(MolPaymentMethod $paymentMethod): PaymentOption | |||
| { | |||
| $paymentOption = new PaymentOption(); | |||
|
|
|||
| /** @var Context $shopContext */ | |||
| $shopContext = $this->module->getService(Context::class); | |||
GytisZum
reviewed
Nov 27, 2024
upgrade/Upgrade-6.2.5.php
Outdated
| return Db::getInstance()->execute($sql); | ||
| } | ||
|
|
||
| function deleteAndUpdatePaymentMethodTitles() { |
There was a problem hiding this comment.
does not look this method is deleting anything
GytisZum
changed the base branch from
release-6.2.5
to
PIPRES-468/title-multilang
GytisZum
merged commit b0d8416
into
mollie:PIPRES-468/title-multilang
2 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created feature for merchants to allow translating payment method titles.
Made a service for easier using
PaymentMethodLangServiceMethods:
savePaymentTitleTranslation- saves new translation or updated existingtrans- gets translation by customer selected language on frontendgetTransList- gets all existing translations for givenpayment_idas array[id_lang => "translation"]