MOL-1294: force label to be empty string on null (#677)

* MOL-1294: force label to be empty string on null * MOL-1294: update test --------- Co-authored-by: Vitalij Mik <[email protected]>
mollie · Jan 9, 2024 · 37d176b · 37d176b
1 parent f411812
commit 37d176b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/src/Components/RefundManager/DAL/RefundItem/RefundItemEntity.php b/src/Components/RefundManager/DAL/RefundItem/RefundItemEntity.php
@@ -175,7 +175,7 @@ public function setRefund(?RefundEntity $refund): void
      */
     public function getLabel(): string
     {
-        return $this->label;
+        return (string) $this->label;
     }
 
     /**

diff --git a/tests/PHPUnit/Components/RefundManager/DAL/RefundItem/RefundItemTest.php b/tests/PHPUnit/Components/RefundManager/DAL/RefundItem/RefundItemTest.php
@@ -77,4 +77,15 @@ public function testDALPayloadNoRefundIfEmpty(): void
         $this->assertArrayNotHasKey('refundId', $payload);
     }
 
+    /**
+     * This test verifies that no errors is thrown if the label have a null value from the database
+     * @return void
+     */
+    public function testLabelHaveEmptyValueOnNUll(): void
+    {
+        $refundItem = new RefundItemEntity();
+        $refundItem->label = null;
+
+        $this->assertSame('',$refundItem->getLabel());
+    }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -175,7 +175,7 @@ public function setRefund(?RefundEntity $refund): void @@
          */
         public function getLabel(): string
         {
-            return $this->label;
+            return (string) $this->label;
         }
         /**
@@ Expand Down @@