PISHPS-306: cypress fix (#850)

* PISHPS-306: cypress fix * PISHPS-306: cypress fix #2
mollie · Oct 1, 2024 · 6849f72 · 6849f72
1 parent a64d76e
commit 6849f72
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 7 deletions.
diff --git a/src/Controller/Api/Order/RefundControllerBase.php b/src/Controller/Api/Order/RefundControllerBase.php
@@ -196,8 +196,13 @@ public function refundOrderID(RequestDataBag $data, Context $context): JsonRespo
             try {
                 $this->creditNoteService->addCreditNoteToOrder($orderId, $refundId, $items, $context);
             } catch (CreditNoteException $exception) {
-                $this->logger->error($exception->getMessage(), ['code' => $exception->getCode(),]);
-                return $this->buildErrorResponse($exception->getMessage());
+                if ($exception->getCode() === CreditNoteException::CODE_ADDING_CREDIT_NOTE_LINE_ITEMS) {
+                    $this->logger->error($exception->getMessage(), ['code' => $exception->getCode(),]);
+                    return $this->buildErrorResponse($exception->getMessage());
+                }
+                if ($exception->getCode() === CreditNoteException::CODE_WARNING_LEVEL) {
+                    $this->logger->warning($exception->getMessage(), ['code' => $exception->getCode(),]);
+                }
             }
         }
 

diff --git a/src/Resources/config/config.xml b/src/Resources/config/config.xml
@@ -312,7 +312,7 @@
         </input-field>
         <input-field type="bool">
             <name>refundManagerCreateCreditNotes</name>
-            <defaultValue>true</defaultValue>
+            <defaultValue>false</defaultValue>
             <label>Create Credit Notes</label>
             <label lang="de-DE">Gutschriften erstellen</label>
             <label lang="nl-NL">Creditnota's maken</label>

diff --git a/src/Service/Refund/Exceptions/CreditNoteException.php b/src/Service/Refund/Exceptions/CreditNoteException.php
@@ -14,9 +14,9 @@ final private function __construct(string $message, int $code)
         parent::__construct($message, $code);
     }
 
-    public static function forAddingLineItems(string $message): CreditNoteException
+    public static function forAddingLineItems(string $message, int $code = self::CODE_ADDING_CREDIT_NOTE_LINE_ITEMS): CreditNoteException
     {
-        return new self($message, self::CODE_ADDING_CREDIT_NOTE_LINE_ITEMS);
+        return new self($message, $code);
     }
 
     public static function forRemovingLineItems(string $message, int $code = self::CODE_REMOVING_CREDIT_NOTE_LINE_ITEMS): CreditNoteException

diff --git a/src/Service/Refund/RefundCreditNoteService.php b/src/Service/Refund/RefundCreditNoteService.php
@@ -126,7 +126,7 @@ public function addCreditNoteToOrder(string $orderId, string $refundId, array $l
         }
 
         if (empty($data['lineItems'])) {
-            throw CreditNoteException::forAddingLineItems(sprintf('No credit note line items found for order. OrderID: %s RefundID: %s', $orderId, $refundId));
+            throw CreditNoteException::forAddingLineItems(sprintf('No credit note line items found for order. OrderID: %s RefundID: %s', $orderId, $refundId), CreditNoteException::CODE_WARNING_LEVEL);
         }
 
         $this->logger->debug('Adding credit note to order', ['orderId' => $orderId, 'refundId' => $refundId, 'lineItems' => $data['lineItems']]);

diff --git a/src/Setting/MollieSettingStruct.php b/src/Setting/MollieSettingStruct.php
@@ -273,7 +273,7 @@ class MollieSettingStruct extends Struct
     /**
      * @var bool
      */
-    protected $refundManagerCreateCreditNotesEnabled = true;
+    protected $refundManagerCreateCreditNotesEnabled = false;
 
     /**
      * @var string