-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve script on page performance #736
Conversation
akf-bw
commented
Apr 15, 2024
- Improved the performance of pages with the mollie javascript by moving it to the page head and adding the "defer" keyword to the script tag to load it already while the browser is parsing the html
- Before this PR the browser had to wait until the full parse of the script to continue parsing the page
@akf-bw thx for the pull request, could you update your master? i pushed some changes to the github pipeline, your branch is out of sync |
@akf-bw your PR does not work, i think in shopware 6.4 there is no layout_head_javascript_hmr_mode block or the template meta.html.twig does not exists there, can you update your pr? |
@BlackScorp Can this PR be merged? The few pipelines down don't seem to be related to this PR, as they also fail in other pipelines in the master branch when I look at through the Github actions. |
@akf-bw sorry it is related, the 6.6 branch was completely green. i just started the pipeline with the current master branch https://github.com/mollie/Shopware6/actions/runs/8706312557 it will be green again. hm.. i have to fix the pipeline first i gues |
@BlackScorp I updated the PR to include the latest changes on the master branch. Can you rerun the pipeline so we can include this PR in the 6.6 update? (which will hopefully released soon) |
@akf-bw i think base_hmr_mode does not exists in 6.5.5.2 and below |
@BlackScorp I finally fixed the issue with older versions and even improved performance again with the checks. |
@BlackScorp Only the "PHP CS Fixer" failed (Because I couldn't run it with my PHP version locally). All other tests work now 🚀 |
@akf-bw thx will do |
@BlackScorp is there a release date for the 6.6 update? |