Merge pull request #39 from mollie/feature/MOL-268/MOL-282

MOL-268/MOL-282: update logic checking
mollie · Aug 13, 2024 · 1c27f5a · 1c27f5a
2 parents 6f44362 + b0c7dd8
commit 1c27f5a
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 14 deletions.
diff --git a/processor/.env.example b/processor/.env.example
@@ -16,6 +16,7 @@ MOLLIE_API_TEST_KEY=<YOUR_MOLLIE_API_TEST_KEY>
 MOLLIE_API_LIVE_KEY=<YOUR_MOLLIE_API_LIVE_KEY>
 MOLLIE_PROFILE_ID=<YOUR_MOLLIE_PROFILE_ID>
 MOLLIE_CARD_COMPONENT=0 ## Either 1 for enable or 0 for disable
+MOLLIE_BANK_TRANSFER_DUE_DATE=14d
 
 ## NGROK
 CONNECTOR_EXTENSION_TOKEN=<YOUR_NGROK_AUTH_TOKEN>
diff --git a/processor/.env.jest b/processor/.env.jest
@@ -12,6 +12,6 @@ MOLLIE_CARD_COMPONENT=0
 CONNECTOR_MODE=test ## Either test or live
 MOLLIE_API_TEST_KEY=test_12345
 MOLLIE_API_LIVE_KEY=live_12345
-MOLLIE_BANK_TRANSFER_DUE_DATE=
+MOLLIE_BANK_TRANSFER_DUE_DATE=14d
 
 CONNECT_SERVICE_URL=http://localhost:3000/processor
diff --git a/processor/package-lock.json b/processor/package-lock.json
diff --git a/processor/package.json b/processor/package.json
@@ -1,7 +1,7 @@
 {
   "name": "shopmacher-mollie-processor",
   "description": "Integration between commercetools and mollie payment service provider",
-  "version": "0.0.27",
+  "version": "0.0.28",
   "main": "index.js",
   "private": true,
   "scripts": {

diff --git a/processor/src/service/payment.service.ts b/processor/src/service/payment.service.ts
@@ -82,16 +82,11 @@ export const handleListPaymentMethodsByPayment = async (ctPayment: Payment): Pro
       );
     }
 
-    methods.splice(
-      methods.findIndex((method: Method) => {
-        return !SupportedPaymentMethods[method.id.toString() as SupportedPaymentMethods];
-      }),
-      1,
-    );
-
     const availableMethods = JSON.stringify({
       count: methods.length,
-      methods: methods.length ? methods : [],
+      methods: methods.length
+        ? methods.filter((method: Method) => SupportedPaymentMethods[method.id.toString() as SupportedPaymentMethods])
+        : [],
     });
 
     ctUpdateActions.push(

diff --git a/processor/tests/utils/config.utils.spec.ts b/processor/tests/utils/config.utils.spec.ts
@@ -2,8 +2,6 @@ import { readConfiguration } from '../../src/utils/config.utils';
 import CustomError from '../../src/errors/custom.error';
 import { describe, expect, test } from '@jest/globals';
 
-const env = process.env;
-
 describe('Test src/utils/config.utils.ts', () => {
   test('should return the correct configuration when all env vars are valid', () => {
     const config = readConfiguration();