refactor: rename mollie card component flag

mollie · Jul 30, 2024 · 5231592 · 5231592
1 parent f01a6de
commit 5231592
Show file tree

Hide file tree

Showing 11 changed files with 14 additions and 14 deletions.
diff --git a/connect.yaml b/connect.yaml
@@ -11,7 +11,7 @@ deployAs:
           description: Commercetools Composable Commerce API region
           required: true
           default: "europe-west1.gcp"
-        - key: ENABLE_MOLLIE_CARD_COMPONENT
+        - key: MOLLIE_CARD_COMPONENT
           description: Enable Mollie cart component (0 or 1)
           required: true
           default: "0"

diff --git a/processor/.env.example b/processor/.env.example
@@ -13,7 +13,7 @@ CTP_API_URL=https://api.<YOUR_CTP_REGION>.commercetools.com
 DEBUG=<INTEGER_VALUE> ## Either 1 for enable or 0 for disable
 MOLLIE_API_KEY=<YOUR_MOLLIE_API_KEY>
 MOLLIE_PROFILE_ID=<YOUR_MOLLIE_PROFILE_ID>
-ENABLE_MOLLIE_CARD_COMPONENT=0 ## Either 1 for enable or 0 for disable
+MOLLIE_CARD_COMPONENT=0 ## Either 1 for enable or 0 for disable
 
 ## NGROK
 CONNECTOR_EXTENSION_TOKEN=<YOUR_NGROK_AUTH_TOKEN>
diff --git a/processor/.env.jest b/processor/.env.jest
@@ -9,6 +9,6 @@ CTP_REGION=europe-west1.gcp
 MOLLIE_API_KEY=12345678901234567890123456789012
 MOLLIE_PROFILE_ID=pfl_12345
 DEBUG=0
-ENABLE_MOLLIE_CARD_COMPONENT=0
+MOLLIE_CARD_COMPONENT=0
 
 CONNECT_SERVICE_URL=http://localhost:3000/processor
diff --git a/processor/package.json b/processor/package.json
@@ -1,7 +1,7 @@
 {
   "name": "shopmacher-mollie-processor",
   "description": "Integration between commercetools and mollie payment service provider",
-  "version": "0.0.19",
+  "version": "0.0.20",
   "main": "index.js",
   "private": true,
   "scripts": {

diff --git a/processor/src/service/payment.service.ts b/processor/src/service/payment.service.ts
@@ -69,7 +69,7 @@ export const handleListPaymentMethodsByPayment = async (ctPayment: Payment): Pro
       ctUpdateActions.push(
         setCustomFields(
           CustomFields.payment.profileId,
-          toBoolean(readConfiguration().mollie.enableCardComponent, true) ? readConfiguration().mollie.profileId : '',
+          toBoolean(readConfiguration().mollie.cardComponent, true) ? readConfiguration().mollie.profileId : '',
         ),
       );
     }

diff --git a/processor/src/types/index.types.ts b/processor/src/types/index.types.ts
@@ -26,6 +26,6 @@ export type ConnectorEnvVars = {
     apiKey: string;
     profileId: string;
     debug: string;
-    enableCardComponent: string;
+    cardComponent: string;
   };
 };
diff --git a/processor/src/utils/config.utils.ts b/processor/src/utils/config.utils.ts
@@ -21,7 +21,7 @@ export const readConfiguration = () => {
       apiKey: process.env.MOLLIE_API_KEY as string,
       debug: process.env.DEBUG as string,
       profileId: process.env.MOLLIE_PROFILE_ID as string,
-      enableCardComponent: process.env.ENABLE_MOLLIE_CARD_COMPONENT as string,
+      cardComponent: process.env.MOLLIE_CARD_COMPONENT as string,
     },
   };
 

diff --git a/processor/src/validators/env.validators.ts b/processor/src/validators/env.validators.ts
@@ -72,7 +72,7 @@ const envValidators = [
   ),
 
   standardString(
-    ['mollie', 'enableCardComponent'],
+    ['mollie', 'cardComponent'],
     {
       code: 'InvalidEnableCardComponent',
       message: 'Enable Mollie card component should be a valid string of either "0" or "1".',

diff --git a/processor/tests/utils/config.utils.spec.ts b/processor/tests/utils/config.utils.spec.ts
@@ -17,7 +17,7 @@ describe('Test src/utils/config.utils.ts', () => {
         apiKey: process.env.MOLLIE_API_KEY,
         debug: process.env.DEBUG,
         profileId: process.env.MOLLIE_PROFILE_ID,
-        enableCardComponent: process.env.ENABLE_MOLLIE_CARD_COMPONENT,
+        cardComponent: process.env.MOLLIE_CARD_COMPONENT,
       },
     });
   });
@@ -57,8 +57,8 @@ describe('Test src/utils/config.utils.ts', () => {
     expect(() => readConfiguration()).toThrow(CustomError);
   });
 
-  test('should throw an error when ENABLE_MOLLIE_CARD_COMPONENT is not defined', () => {
-    delete process.env.ENABLE_MOLLIE_CARD_COMPONENT;
+  test('should throw an error when MOLLIE_CARD_COMPONENT is not defined', () => {
+    delete process.env.MOLLIE_CARD_COMPONENT;
     expect(() => readConfiguration()).toThrow(CustomError);
   });
 });
diff --git a/processor/tests/validators/env.validators.spec.ts b/processor/tests/validators/env.validators.spec.ts
@@ -103,7 +103,7 @@ describe('Test env.validators.ts', () => {
       index1: 8,
       index2: 0,
       field1: 'mollie',
-      field2: 'enableCardComponent',
+      field2: 'cardComponent',
       error: {
         code: 'InvalidEnableCardComponent',
         message: 'Enable Mollie card component should be a valid string of either "0" or "1".',

diff --git a/processor/tests/validators/helpers.validators.spec.ts b/processor/tests/validators/helpers.validators.spec.ts
@@ -236,7 +236,7 @@ describe('Test helpers.validators.ts', () => {
         apiKey: process.env.MOLLIE_API_KEY as string,
         debug: (process.env.DEBUG ?? '0') as string,
         profileId: process.env.MOLLIE_PROFILE_ID as string,
-        enableCardComponent: (process.env.ENABLE_CARD_COMPONENT ?? '0') as string,
+        cardComponent: (process.env.MOLLIE_CARD_COMPONENT ?? '0') as string,
       },
     };
     const error = getValidateMessages(envValidators, vars);
@@ -257,7 +257,7 @@ describe('Test helpers.validators.ts', () => {
         apiKey: process.env.MOLLIE_API_KEY as string,
         debug: (process.env.DEBUG ?? '0') as string,
         profileId: process.env.MOLLIE_PROFILE_ID as string,
-        enableCardComponent: (process.env.ENABLE_CARD_COMPONENT ?? '0') as string,
+        cardComponent: (process.env.MOLLIE_CARD_COMPONENT ?? '0') as string,
       },
     };
     const error = getValidateMessages(envValidators, vars);