Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve delivery methods issue on Apple Pay #712

Conversation

james-windandkite
Copy link
Contributor

  • The code is working on a plain Magento 2 installation.
  • The code follows the PSR-2 code style.
  • When an exception or error is logged the message is accompanied with some context, eg: Error when trying to get the payment status:
  • [] Contains tests for the changed/added code (great if so but not required).
  • I have added a scenario to test my changes.

This PR touches code in the following areas (Check what is applicable):

Frontend

  • Shopping cart
  • Checkout
  • Totals
  • Payment methods

Backend

  • Configuration
  • Order grid
  • Order view
  • Invoice view
  • Credit memo view
  • Shipment view
  • Email sending

Order Processing (Mollie communication)

  • Creating the order
  • Invoicing the order
  • Shipping the order
  • Refunding (credit memo) the order

Please describe the bug/feature/etc this PR contains:
Resolve issue where changing shipping method in ApplePay does not correctly update the quote, resulting in orders failing.

Simplify entire code to remove unrequired saves/collects that are adding to the problem.

Don't set a default shipping method - by the nature of this method a shipping method is always being passed in.

When I change delivery method within Apple Pay popup, it should show a new total in the window including the new shipping amount. Currently the total doesn't update. Apple Pay then authorises the amount without the shipping method, then when it gets requested the total with shipping method it fails resulting in an error.

james-windandkite and others added 4 commits November 3, 2023 17:01
…rectly update the quote, resulting in orders failing.

Simplify entire code to remove unrequired saves/collects that are adding to the problem.

Don't set a default shipping method - by the nature of this method a shipping method is always being passed in.
@Marvin-Magmodules Marvin-Magmodules mentioned this pull request Nov 14, 2023
@Marvin-Magmodules Marvin-Magmodules merged commit 3ff1049 into mollie:master Nov 14, 2023
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants