Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release #715

Merged
merged 19 commits into from
Nov 14, 2023
Merged

Release #715

merged 19 commits into from
Nov 14, 2023

Conversation

michielgerritsen
Copy link
Collaborator

Thank you for creating this pull request! To make the best use of your and our time we created this checklist to get the best possible pull requests:

  • The code is working on a plain Magento 2 installation.
  • The code follows the PSR-2 code style.
  • When an exception or error is logged the message is accompanied with some context, eg: Error when trying to get the payment status:
  • Contains tests for the changed/added code (great if so but not required).
  • I have added a scenario to test my changes.

This PR touches code in the following areas (Check what is applicable):

Frontend

  • Shopping cart
  • Checkout
  • Totals
  • Payment methods

Backend

  • Configuration
  • Order grid
  • Order view
  • Invoice view
  • Credit memo view
  • Shipment view
  • Email sending

Order Processing (Mollie communication)

  • Creating the order
  • Invoicing the order
  • Shipping the order
  • Refunding (credit memo) the order

Other
If you didn't check any boxes above, please describe your changes in this section.

Please describe the bug/feature/etc this PR contains:

When i...

Scenario to test this code:

Open the environment and...

michielgerritsen and others added 19 commits October 26, 2023 13:08
…rectly update the quote, resulting in orders failing.

Simplify entire code to remove unrequired saves/collects that are adding to the problem.

Don't set a default shipping method - by the nature of this method a shipping method is always being passed in.
@Marvin-Magmodules Marvin-Magmodules merged commit d6e3d75 into mollie:master Nov 14, 2023
29 checks passed
@michielgerritsen michielgerritsen deleted the release branch November 21, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants