Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ApiError #363

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Cleanup ApiError #363

merged 2 commits into from
Sep 10, 2024

Conversation

Pimm
Copy link
Collaborator

@Pimm Pimm commented Sep 10, 2024

This PR removes ApiError::getMessage, ApiError::getField, and ApiError::getStatusCode:

  try {
    const payment = await mollieClient.payments.get(…);
  } catch (error) {
-    console.warn(error.getMessage())
+    console.warn(error.message)
  }

The functions were deprecated in eb0abd2. The values returned by these functions are available as (public) properties.

…tusCode.

The values returned by these functions are available as (public) properties.
@Pimm Pimm force-pushed the pimm/api-error-cleanup branch from 6d2018c to 734f57f Compare September 10, 2024 13:57
@Pimm Pimm merged commit b3cfbff into master Sep 10, 2024
5 checks passed
@Pimm Pimm deleted the pimm/api-error-cleanup branch September 10, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants