Cleanup helpers #364
Merged
Cleanup helpers #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjbender
approved these changes
Sep 10, 2024
…ntHelper, ProfileHelper, RefundHelper, SubscriptionHelper. These are functions with no or very little logic in them. I believe including them in the API adds more noise than convenience.
Pimm
force-pushed
the
pimm/helper-cleanup
branch
from
a497491 to
3a63056
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes deprecated helpers from
MandateHelper,OnboardingHelper,PaymentHelper,ProfileHelper,RefundHelper, andSubscriptionHelper. These are functions with no or very little logic in them and can be easily avoided:The functions were deprecated in eb0abd2. I believe including them in the API produces more noise than convenience.