Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: topic client test suite #356

Merged
merged 6 commits into from
Mar 20, 2023
Merged

test: topic client test suite #356

merged 6 commits into from
Mar 20, 2023

Conversation

malandis
Copy link
Contributor

@malandis malandis commented Mar 20, 2023 •
edited
Loading

Implements a test suite for the topic client.

Work toward #343

@malandis malandis marked this pull request as ready for review March 20, 2023 17:32
cprice404
cprice404 reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@cprice404 cprice404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question that Pete left about the empty message case

@malandis malandis merged commit 20361f4 into main Mar 20, 2023
@malandis malandis deleted the test/test-topic-client branch March 20, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cprice404 cprice404 cprice404 approved these changes

@pgautier404 pgautier404 Awaiting requested review from pgautier404

@allenheltondev allenheltondev Awaiting requested review from allenheltondev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@malandis @cprice404 @pgautier404 @allenheltondev