chore: merge console mvp branch back into main #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a great deal of experimentation I was unable to find a setup where we could handle the common dir via symlink and also satisfy all of the tools (jest, eslint, etc.) It seems like the path of least resistance will be to just go ahead and release the common code as its own npm.js package. We will need to be careful to re-export all of the public APIs from that module so that users don't need to express an explicit dependency on the common package.
chore: switch back to treating common as a package
chore: shared integration tests and beginning of ICacheClient interface
…#386) * chore: remove text encoder; rename common package from core to common * fix: export all utils/responses/clients from common lib (#387) * chore: add text encoder polyfill for jest tests * fix: comments * fix: jest setup files * chore: change package name back to core * chore: rename common package --------- Co-authored-by: Matt Straathof <[email protected]> Co-authored-by: Matt Straathof <[email protected]>
* chore; export AuthClient * Trigger Build
* chore; export AuthClient * Trigger Build * fix: how we are encoding base64 strings * fix: linting * chore: update endpoint * chore: add comment to string.ts --------- Co-authored-by: Matt Straathof <[email protected]> Co-authored-by: Matt Straathof <[email protected]>
* feat: Add prompt for request-coalescer example (#367) * feat: Add prompt for request-coalescer example * fix: `setIfNotExists` should accept a `value` not `field` (#385) The API for setIfNotExists has a typo: the parameter for value was mis-named field. * fix: pass other errors to user's subscribe error handler (#388) Prior to this we only passed `NOT_FOUND` gRPC errors to the user's error handler. We should invoke the error handlers on other errors but not subscribe. * fix: support decoding environment variable tokens as v1 tokens (#403) --------- Co-authored-by: rishtigupta <[email protected]> Co-authored-by: Michael Landis <[email protected]> Co-authored-by: Matt Straathof <[email protected]>
* chore: add all public types to index (#426) Prior to this commit, there were quite a few types that were not exported from the main index. This meant that if you needed to reference them in your code your import statement would include the `dist/src` dir explicitly, which is leaking implementation details. This is also problematic for the case where we want to split out a common/core package because those paths would change. To remedy that, this commit adds explicit exports for all of the types that were missing. * chore: remove comments from imports because apparently that breaks the universe --------- Co-authored-by: rishtigupta <[email protected]> Co-authored-by: Michael Landis <[email protected]> Co-authored-by: Matt Straathof <[email protected]>
* chore: migrate common scalar integration tests * fix: add comment for future test consolidation
cprice404
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenerateApiToken(feat: addGenerateApiToken#393)AuthClient(chore: exportAuthClient#397)