feat: Add web sdk configurations #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nand4011
commented
May 18, 2023
pgautier404
reviewed
May 18, 2023
Move transport-strategy and grpc-configuration out of core since it contains options that are only useful for the node sdk. Create web versions of transport strategy and grpc configuration. Create web version of configurations. Plumb deadline millis into the web sdk.
nand4011
force-pushed
the
web-configuration
branch
from
432d0fb to
2c29bae
Compare
cprice404
reviewed
May 18, 2023
Remove the in-region and low-latency configurations and replace them with a browser configuration. Split the deadline and metadata creation into separate functions.
nand4011
force-pushed
the
web-configuration
branch
from
8944650 to
6ffc13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move transport-strategy and grpc-configuration out of core since it contains options that are only useful for the node sdk.
Create web versions of transport strategy and grpc configuration.
Create web version of configurations.
Plumb deadline millis into the web sdk.