Skip to content

Commit

Permalink
Merge pull request #48 from momentohq/release-please-warnings
Browse files Browse the repository at this point in the history 
fix: fix more minor warnings for release-please testing
  • Loading branch information
@nand4011
nand4011 authored Jan 12, 2024
2 parents 42d622d + 812cdf1 commit ee85dc0
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 42 deletions.
22 changes: 0 additions & 22 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -72,30 +72,8 @@ jobs:
with:
arguments: clean build -x jvmTest -x testDebugUnitTest -x testReleaseUnitTest

- name: AVD cache
uses: actions/cache@v3
id: avd-cache
with:
path: |
~/.android/avd/*
~/.android/adb*
key: avd-${{ matrix.api-level }}

- name: create AVD and generate snapshot for caching
if: steps.avd-cache.outputs.cache-hit != 'true'
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ matrix.api-level }}
force-avd-creation: false
emulator-options: -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: false
script: echo "Generated AVD snapshot for caching."

- name: run tests
uses: reactivecircus/android-emulator-runner@v2
with:
api-level: ${{ matrix.api-level }}
force-avd-creation: false
emulator-options: -no-snapshot-save -no-window -gpu swiftshader_indirect -noaudio -no-boot-anim -camera-back none
disable-animations: true
script: ./gradlew connectedCheck
34 changes: 14 additions & 20 deletions src/jvmTest/kotlin/software/momento/kotlin/sdk/CacheClientListTest.kt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ class CacheClientListTest: BaseJvmTestClass() {
"Expected Miss, response is $lengthResponse"
)

var concatResponse =
val concatResponse =
cacheClient.listConcatenateBack(cacheName, listName, values, null, CollectionTtl.of(5.seconds))
assertTrue(concatResponse is ListConcatenateBackResponse.Success)

Expand Down Expand Up @@ -483,7 +483,6 @@ class CacheClientListTest: BaseJvmTestClass() {

fetchResponse = cacheClient.listFetch(cacheName, listName)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
assertEquals(1, fetchResponse.valueListByteArray.size)
assertTrue(fetchResponse.valueListByteArray.any { it.contentEquals(oldValue) })

Expand Down Expand Up @@ -534,13 +533,13 @@ class CacheClientListTest: BaseJvmTestClass() {
val values = listOf("val1", "val2", "val3")
val listName = "listPopFront"

var fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(
fetchResponse is ListFetchResponse.Miss,
"Expected Miss, response is $fetchResponse"
)

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateBack(cacheName, listName, values, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateBackResponse.Success)

Expand All @@ -560,13 +559,13 @@ class CacheClientListTest: BaseJvmTestClass() {
val values = listOf("val1", "val2", "val3")
val listName = "listPopBack"

var fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(
fetchResponse is ListFetchResponse.Miss,
"Expected Miss, response is $fetchResponse"
)

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateBack(cacheName, listName, values, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateBackResponse.Success)

Expand Down Expand Up @@ -594,7 +593,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val values = listOf("val1", "val1", "val2", "val3", "val4")
val listName = "listStringRemove"

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, values, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -606,7 +605,6 @@ class CacheClientListTest: BaseJvmTestClass() {
// Fetch list and verify the values
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
val expectedList = listOf("val2", "val3", "val4")
assertEquals(3, fetchResponse.valueListString.size)
assertTrue(expectedList.containsAll(fetchResponse.valueListString))
Expand All @@ -617,7 +615,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val values = listOf("val1", "val1", "val2", "val3", "val4").map { it.toByteArray() }
val listName = "listByteArrayRemove"

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFrontByteArray(cacheName, listName, values, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -629,7 +627,6 @@ class CacheClientListTest: BaseJvmTestClass() {
// Fetch list and verify the values
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
val expectedList = listOf("val2", "val3", "val4").map { it.toByteArray() }
assertEquals(3, fetchResponse.valueListByteArray.size)
expectedList.forEachIndexed { index, byteArray ->
Expand All @@ -656,7 +653,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listRetainWithPositiveStartEndIndices"
val stringValues = listOf("val1", "val2", "val3", "val4")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -667,7 +664,6 @@ class CacheClientListTest: BaseJvmTestClass() {
val expectedList = listOf("val2", "val3")
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
assertEquals(2, fetchResponse.valueListString.size)
assertTrue(expectedList.containsAll(fetchResponse.valueListString))
}
Expand All @@ -677,7 +673,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listRetainWithNegativeStartEndIndices"
val stringValues = listOf("val1", "val2", "val3", "val4")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -688,7 +684,6 @@ class CacheClientListTest: BaseJvmTestClass() {
val expectedList = listOf("val2", "val3")
val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
assertEquals(2, fetchResponse.valueListString.size)
assertTrue(expectedList.containsAll(fetchResponse.valueListString))
}
Expand All @@ -698,7 +693,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listRetainWithNullStartIndex"
val stringValues = listOf("val1", "val2", "val3", "val4", "val5", "val6", "val7", "val8")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -724,7 +719,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listRetainWithNullEndIndex"
val stringValues = listOf("val1", "val2", "val3", "val4", "val5", "val6", "val7", "val8")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -750,7 +745,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listRetainWithNullStartAndEndIndices"
val stringValues = listOf("val1", "val2", "val3", "val4", "val5", "val6", "val7", "val8")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -759,7 +754,6 @@ class CacheClientListTest: BaseJvmTestClass() {

val fetchResponse = cacheClient.listFetch(cacheName, listName, null, null)
assertTrue(fetchResponse is ListFetchResponse.Hit)
fetchResponse as ListFetchResponse.Hit
assertEquals(stringValues, fetchResponse.valueListString)
}

Expand All @@ -768,7 +762,7 @@ class CacheClientListTest: BaseJvmTestClass() {
val listName = "listName"
val stringValues = listOf("val1", "val2", "val3", "val4", "val5", "val6", "val7", "val8")

var concatenateResponse =
val concatenateResponse =
cacheClient.listConcatenateFront(cacheName, listName, stringValues, null, CollectionTtl.of(5.seconds))
assertTrue(concatenateResponse is ListConcatenateFrontResponse.Success)

Expand All @@ -781,4 +775,4 @@ class CacheClientListTest: BaseJvmTestClass() {
retainResponse = cacheClient.listRetain(cacheName, listName, -3, -5)
assertTrue(retainResponse is ListRetainResponse.Error)
}
}
}

0 comments on commit ee85dc0

Please sign in to comment.