feat: add list collection #43
Conversation
pratik151192
commented
Jan 9, 2024
•
pratik151192
commented
- feat: add all APIs for list collection
| * @param listName The name of the list to fetch from. | ||
| * @param startIndex The starting index of the range (inclusive). | ||
| * @param endIndex The ending index of the range (exclusive). | ||
| * @return The result of the list fetch operation: [ListFetchResponse.Hit] or [ListFetchResponse.Miss]. |
There was a problem hiding this comment.
This should include ListFetchResponse.Error.
| * | ||
| * @param cacheName The name of the cache containing the list. | ||
| * @param listName The name of the list to measure. | ||
| * @return The result of the list length operation: [ListLengthResponse.Success] or [ListLengthResponse.Error]. |
There was a problem hiding this comment.
This Is a Hit/Miss/Error.
| public data class Hit(private val byteArrayValues: List<ByteArray>) : ListFetchResponse { | ||
|
|
||
| /** Retrieves the values as a list of byte arrays. */ | ||
| public fun valueListByteArray(): List<ByteArray> = byteArrayValues |
There was a problem hiding this comment.
In the other responses that return something, we're exposing the values as properties instead of getter functions. GetResponse contains an example. valueListByteArray can be a public val and valueListString can be a lazy initializer.
| public data class Hit(private val value: ByteArray) : ListPopBackResponse { | ||
|
|
||
| /** Retrieves the value as a byte array. */ | ||
| public fun valueByteArray(): ByteArray = value |
There was a problem hiding this comment.
Same here with values vs methods.
| public data class Hit(private val value: ByteArray) : ListPopFrontResponse { | ||
|
|
||
| /** Retrieves the value as a byte array. */ | ||
| public fun valueByteArray(): ByteArray = value |
| require(!listName.isNullOrBlank()) { LIST_NAME_IS_REQUIRED } | ||
| } | ||
|
|
||
| internal fun requireValidValue(value: Any?) { |
There was a problem hiding this comment.
Is this needed? Arguments that can't be null just won't be marked nullable.
| } | ||
|
|
||
| internal fun requireValidListName(listName: String?) { | ||
| require(!listName.isNullOrBlank()) { LIST_NAME_IS_REQUIRED } |
There was a problem hiding this comment.
This is minor, but are empty list names valid? For some reason I thought the server accepted them.
There was a problem hiding this comment.
You are right! Empty list names are indeed accepted.
pratik151192
force-pushed
the
add-list-collection
branch
from
03f35aa to
a08c050
Compare
