feat: add runtime version metadata to the first Momento call #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new Runtime-Version key to the metadata of the first Momento call made by a client. It contains JVM or Android-specific version info. Move the implementation-specific sdk and runtime version logic into an expect class with jvm and android versions.
Switch the android build on github to ubuntu, since it is now recommended as the faster and cheaper way of running and android emulator.
|
@nand4011 Is this ready for review or should I wait till the android build passes? |
|
@nand4011 just bumping this I saw this come up in my github notifications |
Add client type to agent string. Switch isUserAgentSent in UserHeaderInterceptor to a local variable so the agent header will be sent with every client creation instead of once per run of the program.
|
You can review it. They android build issue is a github thing that I need to figure out. |
Use ubuntu 22.04 instead of ubuntu latest for running the android tests because the emulator runner has issues on 24.04 ReactiveCircus/android-emulator-runner#400 Add some improved test failure messages.
nand4011
force-pushed
the
runtime-version
branch
from
e74abde to
2f60914
Compare
cprice404
reviewed
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Runtime-Version key to the metadata of the first Momento call made by a client. It contains JVM or Android-specific version info.
Move the implementation-specific sdk and runtime version logic into an expect class with jvm and android versions.