Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tokenId optional parameter for generateDisposableToken docs #1444

Merged
merged 5 commits into from
Jan 10, 2025
Merged

chore: add tokenId optional parameter for generateDisposableToken docs #1444

merged 5 commits into from
Jan 10, 2025

Conversation

anitarua
Copy link
Collaborator

@anitarua anitarua commented Dec 18, 2024 •
edited
Loading

Will be pointed to by the rust topics example updated to show publisher_id: momentohq/client-sdk-rust#418

@anitarua anitarua requested a review from a team December 18, 2024 22:26
pgautier404
pgautier404 previously approved these changes Jan 8, 2025
View reviewed changes
@anitarua anitarua requested review from pgautier404 and a team January 8, 2025 23:16
nand4011
nand4011 previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only nit is that the capitalization, presence of a starting article, and punctuation are different between the parameters, optional parameters, and return values.

rishtigupta
rishtigupta previously approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@rishtigupta rishtigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitarua anitarua dismissed stale reviews from rishtigupta and nand4011 via 7a2fbe9 January 10, 2025 17:59
@anitarua
Copy link
Collaborator Author

My only nit is that the capitalization, presence of a starting article, and punctuation are different between the parameters, optional parameters, and return values.

I think I got them all, but let me know if you see more!

nand4011
nand4011 previously approved these changes Jan 10, 2025
View reviewed changes
@anitarua anitarua requested a review from nand4011 January 10, 2025 18:04
nand4011
nand4011 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Contributor

@nand4011 nand4011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@anitarua anitarua merged commit ee086cf into main Jan 10, 2025
4 checks passed
@anitarua anitarua deleted the token-id branch January 10, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nand4011 nand4011 nand4011 approved these changes

@pgautier404 pgautier404 Awaiting requested review from pgautier404

@rishtigupta rishtigupta Awaiting requested review from rishtigupta

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anitarua @nand4011 @pgautier404 @rishtigupta