added more callbacks

[0xeb]

No description provided.

[0xeb]

sorry, the formatting checks is schizophrenic. the syscalls.cpp is formatted with clang formatter and it keeps complaining.
@momo5502

[robert-yates]

sorry, the formatting checks is schizophrenic. the syscalls.cpp is formatted with clang formatter and it keeps complaining. @momo5502

i have this problem at work also sometimes. different clang format binaries can have slight changes. in this case it appears the workflow is using clang-format v19, check you have the same version

[0xeb]

@robert-yates , I use Ctrl-K, Ctrl-D shortcut from within visual studio 2022 (latest update).

what else do I need to use for that? any detailed pointers?

[robert-yates]

@robert-yates , I use Ctrl-K, Ctrl-D shortcut from within visual studio 2022 (latest update).

what else do I need to use for that? any detailed pointers?

hmm im not familiar with the visual studio implementation, however i would download llvm 19.1.0 from llvm.org and add the clang-format binary at the start of your global path env and restart VS and see it it picks up that instead

[0xeb]

@robert-yates thanks, let's see

[momo5502]

@robert-yates , I use Ctrl-K, Ctrl-D shortcut from within visual studio 2022 (latest update).

what else do I need to use for that? any detailed pointers?

that uses the integrated visual studio formatter which won't use clang-format.
I use this plugin: https://marketplace.visualstudio.com/items?itemName=caphyon.ClangPowerTools
Then you only have to click this button:

In the settings you can also configure format-on-save, which is nice.

[0xeb]

Thanks for the plugin hint @momo5502. I think that’s the one you told me about before. Anyway, now the formatter works and I could tell it which tool version to use. The PR should be ready now.

[momo5502]

Thanks for the plugin hint @momo5502. I think that’s the one you told me about before. Anyway, now the formatter works and I could tell it which tool version to use. The PR should be ready now.

yep. directx install hung up. sadly that happens sometimes :( need to investigate why. i retriggered the workflow. let's see if it's green :D

I am not sure how to resolve this change request, but I am pretty sure I finished all the requested changes

[0xeb]

Ping @momo5502 ?