-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do we want a QC check to ensure that all deprecated classes have an obsoletion reason? #6968
Comments
it would be nice to have this but probably more effort than it is worth to go back and add obs reasons to all of the terms that do not already have one |
One option is to give all the ones that are currently missing an obsolescence reason a blanket reason (say, "out of scope") or similar, so that we can activate the QC check for the future. We could also create a (closed) issue explaining the obsoletion "Deprecated classes without an obsoletion reason" and link all classes to this ticket; this ticket could then have an explanation that we did not track obsoletion reasons when this class was obsoleted, but if you want to know why it was obsoleted, you can open a new ticket? |
I like both of these ideas @matentzn. I'm in favor of doing this. |
I am in favor of adding the qc check and also adding the blanket reason with a ticket reference for any class that does not already have an obsoletion reason. |
Yes, I didnt think to also say this clearly: Do we think that all obsoleted classes should be linked to a GitHub issue? I think this would be a pretty awesome show of transparency as well. |
Yes to everything BUT I think there are a lot of "old" obsoleted classes for which there might not be a GH issue. So we need to have a plan for these. |
The same idea as above: a blanket issue explaining that this term was obsoleted before there was a system, and there is therefore no issue tracker connected. |
I am in favor of all of this |
|
If we decide against it, just close this issue here.
The text was updated successfully, but these errors were encountered: