🧹 Draft: Improve azure cnquery packs #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HRouhani
changed the title
This comment has been minimized.
This comment has been minimized.
HRouhani
force-pushed
the
hossein/azure-cnquery-packs
branch
from
183de9d to
82b0220
Compare
tas50
reviewed
Sep 29, 2023
| mql: azure.subscription.resources | ||
| - uid: mondoo-asset-inventory-azure-mfa-users |
There was a problem hiding this comment.
We need to rework this in a data gathering way, not a security way. We could make it "Retrieve all users in the subscription and their MFA status"
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
Signed-off-by: Hossein Rouhani <[email protected]>
HRouhani
force-pushed
the
hossein/azure-cnquery-packs
branch
from
82b0220 to
6cbe350
Compare
Signed-off-by: Hossein Rouhani <[email protected]>
tas50
reviewed
Oct 2, 2023
| mql: azure.subscription.id | ||
| mql: azure.subscription.subscriptionId | ||
| - uid: mondoo-asset-inventory-azure-subscription-name | ||
| title: Retrieve Azure subscription Name |
There was a problem hiding this comment.
Suggested change
| title: Retrieve Azure subscription Name | |
| title: Retrieve Azure subscription name |
|
Closing this out to do it in the new policy instead |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvement related to --> https://www.notion.so/mondoo/SOC2-query-pack-required-resources-57920bb45b6a4da7b8f3612cba525849#4dbb1f9d50744f6c8e646f730f9b7f99
All needed resources will be documented at the end of this document: https://www.notion.so/mondoo/Azure-Security-Policy-d1443f97e0bf4634b38bd0b27a0c67da
Still Ongoing, I believe most of the stuff we can implement.