🧹 apply changes from code review

mondoohq · Aug 12, 2024 · 7548494 · 7548494
1 parent c531f96
commit 7548494
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/providers/ms365/resources/groups.go b/providers/ms365/resources/groups.go
@@ -54,7 +54,7 @@ func (a *mqlMicrosoftGroup) members() ([]interface{}, error) {
 		}
 
 		// if the user is already indexed, we can reuse it
-		userResource, ok := mqlMicrsoftResource.userById(*memberId)
+		userResource, ok := mqlMicrosoftResource.userById(*memberId)
 		if ok {
 			res = append(res, userResource)
 			continue
@@ -66,7 +66,7 @@ func (a *mqlMicrosoftGroup) members() ([]interface{}, error) {
 		if err != nil {
 			return nil, err
 		}
-		mqlMicrsoftResource.index(newUserResource.(*mqlMicrosoftUser))
+		mqlMicrosoftResource.index(newUserResource.(*mqlMicrosoftUser))
 		res = append(res, newUserResource)
 	}
 	return res, nil

diff --git a/providers/ms365/resources/microsoft.go b/providers/ms365/resources/microsoft.go
@@ -13,8 +13,6 @@ import (
 type mqlMicrosoftInternal struct {
 	// index users by id
 	idxUsersById map[string]*mqlMicrosoftUser
-	// index users by principal name
-	idxUsersByPrincipalName map[string]*mqlMicrosoftUser
 }
 
 // initIndex ensures the user indexes are initialized,
@@ -23,16 +21,12 @@ func (a *mqlMicrosoft) initIndex() {
 	if a.idxUsersById == nil {
 		a.idxUsersById = make(map[string]*mqlMicrosoftUser)
 	}
-	if a.idxUsersByPrincipalName == nil {
-		a.idxUsersByPrincipalName = make(map[string]*mqlMicrosoftUser)
-	}
 }
 
 // index adds a user to the internal indexes
 func (a *mqlMicrosoft) index(user *mqlMicrosoftUser) {
 	a.initIndex()
 	a.idxUsersById[user.Id.Data] = user
-	a.idxUsersByPrincipalName[user.UserPrincipalName.Data] = user
 }
 
 // userById returns a user by id if it exists in the index