Skip to content

Commit

Permalink
Rename the ec2-volume and ec2-snapshot platforms to be EBS (#3019)
Browse files Browse the repository at this point in the history
The API calls these EC2, which makes sense from an SDK organization
standpoint, but doesn't reflect what these platforms are call. The
console and documentation calls these EBS volumes/snapshots. This is a
breaking change, but the blast radius is very small at this point since
discover is not enabled by default. V10 is the perfect time to make this
before we enable fine grained scanning by default.

Signed-off-by: Tim Smith <[email protected]>
  • Loading branch information
tas50 authored Jan 14, 2024
1 parent d84e095 commit 79272a0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions providers/aws/connection/platform.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ func getTitleForPlatformName(name string) string {
return "AWS VPC"
case "aws-security-group":
return "AWS Security Group"
case "aws-ec2-volume":
return "AWS EC2 Volume"
case "aws-ec2-snapshot":
return "AWS EC2 Snapshot"
case "aws-ebs-volume":
return "AWS EBS Volume"
case "aws-ebs-snapshot":
return "AWS EBS Snapshot"
case "aws-iam-user":
return "AWS IAM User"
case "aws-iam-group":
Expand Down
4 changes: 2 additions & 2 deletions providers/aws/resources/discovery_conversion.go
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,9 @@ func getPlatformName(awsObject awsObject) string {
case "securitygroup":
return "aws-security-group"
case "volume":
return "aws-ec2-volume"
return "aws-ebs-volume"
case "snapshot":
return "aws-ec2-snapshot"
return "aws-ebs-snapshot"
case "instance":
return "aws-ec2-instance"
}
Expand Down

0 comments on commit 79272a0

Please sign in to comment.