🐛 fix github provider load secret from inventory

Signed-off-by: Salim Afiune Maya <[email protected]>

providers/github/connection/connection.go

@@ -84,7 +84,7 @@ func connectionOptionsFromConfigOptions(conf *inventory.Config) (opts githubConn
 			}
 
 		case vault.CredentialType_password:
-			if opts.Token != "" {
+			if opts.Token == "" {
 				opts.Token = string(cred.Secret)
 			}
 		}
@@ -94,6 +94,9 @@ func connectionOptionsFromConfigOptions(conf *inventory.Config) (opts githubConn
 }
 
 func NewGithubConnection(id uint32, asset *inventory.Asset) (*GithubConnection, error) {
+	if asset.Connections == nil {
+		return nil, errors.New("no connection details for the asset")
+	}
 	connectionOpts := connectionOptionsFromConfigOptions(asset.Connections[0])
 
 	var client *github.Client

providers/github/connection/connection_test.go

@@ -1,10 +1,7 @@
 // Copyright (c) Mondoo, Inc.
 // SPDX-License-Identifier: BUSL-1.1
 
-//go:build debugtest
-// +build debugtest
-
-package github
+package connection
 
 import (
 	"context"
@@ -14,16 +11,34 @@ import (
 	"github.com/google/go-github/v67/github"
 	"github.com/stretchr/testify/require"
 	"go.mondoo.com/cnquery/v11/providers-sdk/v1/inventory"
+	"go.mondoo.com/cnquery/v11/providers-sdk/v1/vault"
 )
 
-func TestGithub(t *testing.T) {
+func TestGithubNoConnection(t *testing.T) {
 	os.Setenv("GITHUB_TOKEN", "")
-	p, err := NewGithubConnection(0, &inventory.Config{})
-	require.NoError(t, err)
+	_, err := NewGithubConnection(0, &inventory.Asset{})
+	require.Error(t, err)
+}
 
-	client := p.Client()
+func TestGithubValidConnection(t *testing.T) {
+	_, err := NewGithubConnection(0, &inventory.Asset{
+		Connections: []*inventory.Config{{
+			Credentials: []*vault.Credential{{
+				Type:   vault.CredentialType_password,
+				Secret: []byte("super_secret"),
+			},
+			},
+		},
+		},
+	})
+	require.NoError(t, err)
+}
 
+func TestGithubNeedsFix(t *testing.T) {
+	t.Skip()
+	p, err := NewGithubConnection(0, &inventory.Asset{})
 	orgName := "mondoohq"
+	client := p.Client()
 	ctx := context.Background()
 	org, _, err := client.Organizations.Get(ctx, orgName)
 	require.NoError(t, err)