Skip to content

Commit

Permalink
Be more consistent with create times
Browse files Browse the repository at this point in the history
None of these properties have been released yet so this is our chance to
fix this

Signed-off-by: Tim Smith <[email protected]>
  • Loading branch information
tas50 committed Oct 3, 2023
1 parent 140b762 commit a8ccaa9
Show file tree
Hide file tree
Showing 5 changed files with 24 additions and 24 deletions.
4 changes: 2 additions & 2 deletions providers/aws/resources/aws.lr
Original file line number Diff line number Diff line change
Expand Up @@ -1000,7 +1000,7 @@ private aws.s3.bucket @defaults("arn") {
// False if the bucket no longer exists (stale reference)
exists bool
// Date the bucket was created
creationDate time
createdTime time
}

// Amazon S3 Bucket Grant
Expand Down Expand Up @@ -1262,7 +1262,7 @@ private aws.rds.dbinstance @defaults("id region engine engineVersion") {
// Indicates whether minor version patches are applied automatically
autoMinorVersionUpgrade bool
// The creation date of the RDS instance
creationDate time
createdTime time
}

// Amazon ElastiCache
Expand Down
28 changes: 14 additions & 14 deletions providers/aws/resources/aws.lr.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions providers/aws/resources/aws.lr.manifest.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1809,7 +1809,7 @@ resources:
availabilityZone:
min_mondoo_version: 9.0.0
backupRetentionPeriod: {}
creationDate:
createdTime:
min_mondoo_version: 9.0.0
dbInstanceClass:
min_mondoo_version: 5.19.1
Expand Down Expand Up @@ -1977,7 +1977,7 @@ resources:
acl: {}
arn: {}
cors: {}
creationDate:
createdTime:
min_mondoo_version: 9.0.0
defaultLock: {}
encryption: {}
Expand Down
2 changes: 1 addition & 1 deletion providers/aws/resources/aws_rds.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func (a *mqlAwsRds) getDbInstances(conn *connection.AwsConnection) []*jobpool.Jo
"storageType": llx.StringData(convert.ToString(dbInstance.StorageType)),
"storageIops": llx.IntData(convert.ToInt64From32(dbInstance.Iops)),
"tags": llx.MapData(rdsTagsToMap(dbInstance.TagList), types.String),
"creationDate": llx.TimeData(toTime(dbInstance.InstanceCreateTime)),
"createdTime": llx.TimeData(toTime(dbInstance.InstanceCreateTime)),
})
if err != nil {
return nil, err
Expand Down
10 changes: 5 additions & 5 deletions providers/aws/resources/aws_s3.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,11 @@ func (a *mqlAwsS3) buckets() ([]interface{}, error) {
}
mqlS3Bucket, err := CreateResource(a.MqlRuntime, "aws.s3.bucket",
map[string]*llx.RawData{
"name": llx.StringData(convert.ToString(bucket.Name)),
"arn": llx.StringData(fmt.Sprintf(s3ArnPattern, convert.ToString(bucket.Name))),
"exists": llx.BoolData(true),
"location": llx.StringData(region),
"creationDate": llx.TimeData(toTime(bucket.CreationDate)),
"name": llx.StringData(convert.ToString(bucket.Name)),
"arn": llx.StringData(fmt.Sprintf(s3ArnPattern, convert.ToString(bucket.Name))),
"exists": llx.BoolData(true),
"location": llx.StringData(region),
"createdTime": llx.TimeData(toTime(bucket.CreationDate)),
})
if err != nil {
return nil, err
Expand Down

0 comments on commit a8ccaa9

Please sign in to comment.