Skip to content

Commit

Permalink
⭐️ improve rds resource (#4527)
Browse files Browse the repository at this point in the history
* 🧹 improve aws.rds resources

- expose certificate configuration
- expose activity stream mode and status for cluster and instance

* ⭐️ aws rds pending maintainance actions

* ⭐️ expose aws rds instance monitoring interval

* 🧹 expose aws rds network type

* Apply suggestions from code review

Co-authored-by: Preslav Gerchev <[email protected]>

* 🧹 improve rds resource after code review

---------

Co-authored-by: Preslav Gerchev <[email protected]>
  • Loading branch information
chris-rock and preslavgerchev authored Aug 12, 2024
1 parent 0b3b6c9 commit bc8a5ac
Show file tree
Hide file tree
Showing 5 changed files with 788 additions and 136 deletions.
1 change: 1 addition & 0 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ exo
gcfs
gcs
geomatchstatement
gibibytes
gistfile
gpu
gvnic
Expand Down
58 changes: 56 additions & 2 deletions providers/aws/resources/aws.lr
Original file line number Diff line number Diff line change
Expand Up @@ -2026,6 +2026,8 @@ aws.rds {
dbClusters() []aws.rds.dbcluster
// List of RDS database clusters
clusters() []aws.rds.dbcluster
// List of all pending maintenance actions for the database instance
allPendingMaintenanceActions() []aws.rds.pendingMaintenanceAction
}

// Amazon RDS Backup Setting
Expand Down Expand Up @@ -2112,6 +2114,20 @@ private aws.rds.dbcluster @defaults("id region") {
backupSettings() []aws.rds.backupsetting
// The life cycle type for the database engine. By default, this value is set to `open-source-rds-extended-support`, which enrolls your DB engine into Amazon RDS Extended Support. At the end of standard support, you can avoid charges for Extended Support by setting the value to `open-source-rds-extended-support-disabled`. In this case, creating the DB engine will fail if the DB major version is past its end of standard support date.
engineLifecycleSupport string
// Expiration date for the instance certificate
certificateExpiresAt time
// ID of the Certificate Authority
certificateAuthority string
// Whether IAM database authentication is enabled
iamDatabaseAuthentication bool
// Mode of the database activity stream
activityStreamMode string
// Status of the database activity stream
activityStreamStatus string
// Interval, in seconds, between points when Enhanced Monitoring metrics are collected
monitoringInterval int
// Network type of the DB instance
networkType string
}

// Amazon RDS snapshot
Expand Down Expand Up @@ -2140,6 +2156,8 @@ private aws.rds.snapshot @defaults("id region type encrypted createdAt") {
status string
// The port that the database instance or cluster listens on
port int
// Allocated storage size in gibibytes (GiB)
allocatedStorage int
// The creation date of the snapshot
createdAt time
}
Expand All @@ -2148,6 +2166,8 @@ private aws.rds.snapshot @defaults("id region type encrypted createdAt") {
private aws.rds.dbinstance @defaults("id region engine engineVersion") {
// ARN for the database instance
arn string
// Identifier for the database instance
id string
// Name of the database instance
name string
// Number of days for which automated snapshots are retained
Expand All @@ -2174,8 +2194,8 @@ private aws.rds.dbinstance @defaults("id region engine engineVersion") {
deletionProtection bool
// Whether the instance is a Multi-AZ deployment
multiAZ bool
// Identifier for the database instance
id string
// Interval, in seconds, between points when Enhanced Monitoring metrics are collected
monitoringInterval int
// ARN of the CloudWatch log stream that receives the enhanced monitoring metrics data
enhancedMonitoringResourceArn string
// Tags for the database instance
Expand Down Expand Up @@ -2210,6 +2230,40 @@ private aws.rds.dbinstance @defaults("id region engine engineVersion") {
subnets() []aws.vpc.subnet
// The life cycle type for the database engine. By default, this value is set to `open-source-rds-extended-support`, which enrolls your DB engine into Amazon RDS Extended Support. At the end of standard support, you can avoid charges for Extended Support by setting the value to `open-source-rds-extended-support-disabled`. In this case, creating the DB engine will fail if the DB major version is past its end of standard support date.
engineLifecycleSupport string
// Expiration date for the instance certificate
certificateExpiresAt time
// ID of the Certificate Authority
certificateAuthority string
// Whether IAM database authentication is enabled
iamDatabaseAuthentication bool
// Assigned IAM instance profile
customIamInstanceProfile string
// Mode of the database activity stream
activityStreamMode string
// Status of the database activity stream
activityStreamStatus string
// List of pending maintenance actions for the database instance
pendingMaintenanceActions() []aws.rds.pendingMaintenanceAction
// Network type of the DB instance
networkType string
}

// Amazon RDS pending maintenance action
private aws.rds.pendingMaintenanceAction {
// ARN for resource
resourceArn string
// Action to take
action string
// Description of the action
description string
// Auto applied after date
autoAppliedAfterDate time
// Current apply date
currentApplyDate time
// Forced apply date
forcedApplyDate time
// Opt-in status
optInStatus string
}

// Amazon ElastiCache
Expand Down
Loading

0 comments on commit bc8a5ac

Please sign in to comment.