Skip to content

Commit

Permalink
Update to the latest spellcheck GH Action (#1989)
Browse files Browse the repository at this point in the history
Sync the configs as well

Signed-off-by: Tim Smith <[email protected]>
  • Loading branch information
tas50 authored Sep 29, 2023
1 parent ce2f1fd commit c3afb2a
Show file tree
Hide file tree
Showing 9 changed files with 22 additions and 30 deletions.
24 changes: 6 additions & 18 deletions .github/actions/spelling/expect.txt
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
Acked
activitylog
aks
asns
Auths
autoaccept
autoscaler
awsconf
awsp
backupconfiguration
bigquery
BLOCKLIST
cavium
cdn
certificatechains
cmek
cosmosdb
cryptokey
customresources
datapath
Expand All @@ -30,19 +23,19 @@ hostkeys
iap
iex
ilb
iotedge
ingresstls
iotedge
linux
loggingservice
managedzone
mcr
messagestoragepolicy
mfs
mgroup
Mpim
nodepool
oci
opc
nullgroup
opcplc
opcua
Pids
postgre
pushconfig
Expand All @@ -51,21 +44,16 @@ resourcegroup
Sas
serviceprincipals
Snat
spdx
sph
spo
sqlserver
sshkeys
testutils
toplevel
tpu
uint
vcn
vcns
vdcs
vmknics
Vtpm
vulnerabilityassessmentsettings
wil
mgroup
muser
testutils
nullgroup
7 changes: 6 additions & 1 deletion .github/actions/spelling/line_forbidden.patterns
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Detect common combinations of valid words that are in fact invalid.
# Detect common combinations of valid words that are in fact invalid.
# Useful for brand capitalizations

#
Expand All @@ -9,6 +9,10 @@
\sthe Mondoo Platform\b
\sMondoo platform\b

# s.b. Compliance Hub
\scompliance hub\b
\sCompliance hubplatform\b

#
# Industry Terms
#
Expand Down Expand Up @@ -98,6 +102,7 @@

# s.b. Red Hat
\bRedHat\b
\bRedhat\b

# s.b. AlmaLinux
\bAlma Linux\b
Expand Down
1 change: 0 additions & 1 deletion .github/actions/spelling/reject.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,3 @@ Sorce
^untilling$
^wether.*
\w*(?<!right-)click
press
6 changes: 3 additions & 3 deletions .github/workflows/spell-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ jobs:
steps:
- name: check-spelling
id: spelling
uses: check-spelling/[email protected].21
uses: check-spelling/[email protected].22
with:
suppress_push_for_open_pull_request: 1
checkout: true
post_comment: 0
dictionary_source_prefixes: '{"mondoo": "https://raw.githubusercontent.com/mondoohq/spellcheck-dictionary/main/", "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20220816/dictionaries/"}'
dictionary_source_prefixes: '{"mondoo": "https://raw.githubusercontent.com/mondoohq/spellcheck-dictionary/main/", "cspell": "https://raw.githubusercontent.com/check-spelling/cspell-dicts/v20230509/dictionaries/"}'
extra_dictionaries:
cspell:aws/aws.txt
cspell:filetypes/filetypes.txt
Expand All @@ -47,7 +47,7 @@ jobs:
if: (success() || failure()) && needs.spelling.outputs.followup
steps:
- name: comment
uses: check-spelling/[email protected].21
uses: check-spelling/[email protected].22
with:
checkout: true
task: ${{ needs.spelling.outputs.followup }}
2 changes: 1 addition & 1 deletion examples/complex.mql.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ packs:
- asset.family.contains("unix")

# Queries can be grouped together, which gives us additional filters on each group.
# For example: the first group is for MacOS only, the second for is for Linux
# For example: the first group is for macOS only, the second for is for Linux
groups:
- filters: asset.platform == "macos"
queries:
Expand Down
2 changes: 1 addition & 1 deletion providers-sdk/v1/vault/keyring/keyring.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ func New(serviceName string) *Vault {
allowedBackends: []keyring.BackendType{
// Windows
keyring.WinCredBackend,
// MacOS
// macOS
keyring.KeychainBackend,
// Linux
keyring.SecretServiceBackend,
Expand Down
3 changes: 1 addition & 2 deletions providers/os/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
## os provider for cnquery/cnspec

This provides makes the operating system accessible, including Linux, MacOS, Windows and many more.
This provides makes the operating system accessible, including Linux, macOS, Windows and many more.

It provides connectors for Local OS, SSH, WinRM, and Docker.

5 changes: 3 additions & 2 deletions providers/os/connection/fs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ This transport reads a directory and treats it as its own platform. This is usef

## Testing

If you need to test a remote linux system on macos, it is possible to spin up the machine and mount the whole filesystem to your local machine.
If you need to test a remote Linux system on macOS, it is possible to spin up the machine and mount the whole filesystem to your local machine.

```bash
# NOTE: make sure you do NOT run the following as sudo
Expand Down Expand Up @@ -34,6 +34,7 @@ On debian, the needed package is called `sshfs`.
When you want to connect to a Vagrant VM, you need to add an ssh key to the root user.

Then you can use root, to mount via sshfs:

```bash
sshfs -o default_permissions [email protected]:/ ./mnt -o IdentityFile=/home/you/.ssh/id_rsa -o Port=2222
```
```
2 changes: 1 addition & 1 deletion providers/os/resources/services/launchd.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func ParseServiceLaunchD(input io.Reader) ([]*Service, error) {
return services, nil
}

// MacOS is using launchd as default service manager
// macOS is using launchd as default service manager
type LaunchDServiceManager struct {
conn shared.Connection
}
Expand Down

0 comments on commit c3afb2a

Please sign in to comment.