🐛 fix asset name for local, ssh conn #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
changed the title
vjeffrey
force-pushed
the
vj/local-ssh-name
branch
from
71b0d19 to
7911fc4
Compare
czunker
reviewed
Sep 18, 2023
providers/os/id/ids/ids.go
Outdated
|
|
||
| // FIXME: DEPRECATED, remove in v9.0 vv | ||
| // this is now cloud-detect | ||
| IdDetector_AwsEc2 = "aws-ec2" |
There was a problem hiding this comment.
As this PR is for v9 and detection, perhaps we can directly remove it here.
|
Gave it a try with local and ssh to a vagrant box and it works. 👍 Directly using the vagrant provider does not work. I'll create an issue for that. |
vjeffrey
force-pushed
the
vj/local-ssh-name
branch
from
8033ada to
a9ae4e7
Compare
czunker
approved these changes
Sep 19, 2023
|
Thanks @vjeffrey |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes the asset name detection for local and ssh - it's a portover from v8.
this still needs some cleanup, ill get back to it this weekend. ran outta steam.