Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 let providers/config use providers/builtin_dev.go #1756

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

arlimus
Copy link
Member

@arlimus arlimus commented Sep 17, 2023

After #1753

This way we avoid generating the same core+mock code all the time and are more resiliant to changes of these static builtins. At the same time it creates one clean file that is always auto-generated.

@arlimus arlimus changed the title 🧹 move providers/config to providers/builtin_dev 🧹 let providers/config use providers/builtin_dev.go Sep 17, 2023
This way we avoid generating the same core+mock code all the time and are more resiliant to changes of these static builtins. At the same time it creates one clean file that is always auto-generated.

Signed-off-by: Dominik Richter <[email protected]>
@arlimus arlimus force-pushed the dom/clean-configure branch from 3a716be to 7427c3f Compare September 17, 2023 22:19
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah!

@chris-rock chris-rock merged commit 469c69e into main Sep 18, 2023
@chris-rock chris-rock deleted the dom/clean-configure branch September 18, 2023 03:54
@github-actions github-actions bot locked and limited conversation to collaborators Sep 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants