🐛 ensure gitlab discovered assets have unique platform ids #1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vjeffrey
force-pushed
the
vj/platformidsgitlab
branch
from
efd50f7 to
56e533d
Compare
vjeffrey
commented
Sep 18, 2023
| if err == nil && len(assets) > 0 { | ||
| for i := range assets { | ||
| if len(assets[i].PlatformIds) > 0 { | ||
| assets[i].PlatformIds[0] = assets[i].PlatformIds[0] + "/" + project.Name |
There was a problem hiding this comment.
the terraform platform ids in the group i was testing were coming back as the same, so i added the project name as a safeguard..
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.