🐛 ensure we use the credential token for gitlab scan #1793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the error i encountered is reproducible by running
unset SSH_AUTH_SOCKand then runningDEBUG=1 cnquery shell gitlab --group mondoolabs --token TOKENyou should see it fail out when cloning the repos
(with this change it should just work. in my test i have one repo i can't clone due to perms, so it get 36 assets discovered)
i'm a little uncertain about this change, i would have expected some process before resolve, like the enrich assets one, to take care of doing this
but i did test this on two diff machines and got the same result on both